Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automatic acknowledge type naming more consistent #62

Closed
imkunet opened this issue Jul 4, 2021 · 2 comments
Closed

Make automatic acknowledge type naming more consistent #62

imkunet opened this issue Jul 4, 2021 · 2 comments

Comments

@imkunet
Copy link

imkunet commented Jul 4, 2021

Summary

The naming for determining the mode of automatic interaction acknowledgement is inconsistent.

Current Behavior

Right now in the component builder the field that determines the mode of automatic interaction acknowledgement is called "ackType" whereas the slash command's automatic acknowledgement field is called "autoAckType".

Slash Commands Field
Components Field

Preferred Behavior

The preferred behavior is where the field names are consistent across the two different fields

Suggestions

Personally I would like to see it be called "autoAckType" because the field name is easier for beginners using autocomplete (like myself) to understand exactly what this field controls quickly.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 4, 2021

Hello, and thanks for opening an issue! As this is the first time you've created an issue on this repository, we'd just like to offer you a warm welcome to the project, and the following pointers:

  • Most importantly, all issues must adhere to our Code of Conduct. Please give it a quick read if you haven't already.

  • While our team is passionate about the projects we've created here, we're all volunteers. Please don't be offended if it takes time for us to get to your issue - we'll be here as soonas we can be!

  • Please provide as much information as possible when asking a question, reporting a problem, or submitting a feature request. This will help us to address your issue quickly and efficiently. If you forgot to add some information, no worries - feel free to edit the issue and add anything you missed!

    Thanks for contacting us! If you have any further questions, please feel free to join us on Discord in the #dev-kotdis channel (or #kordex-discussion for Kord Extensions projects), or to contact a staff member directly.

@gdude2002
Copy link
Member

This is fixed in the latest snapshot - the property name was actually autoAck, not autoAckType or ackType.

I've deprecated the old name at the ERROR level, so that should help you with renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants