-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks overhaul #58
Comments
I decided to take a different approach to this, as This is in |
This is now in a release version, so I'll consider it good. Feel free to open another issue if there are problems. |
As it stands, checks are pretty simple and there's a lot of power in their simplicity. However, there are some situations where checks are not enough, and the user needs to have a message returned to them.
This issue proposes a new style of checks - very similar to the current style, they would simply take an event and return a value. However, that value should be a
CheckResult
rather than a boolean - this would allow check developers to specify a message or translation key to be returned to the user, if the check fails.This should be configurable on a per-command and per-extension basis as well.
The text was updated successfully, but these errors were encountered: