test(viewer): async_states SkeletonLayout proptest surface (WBS-6.2 #458) - #473
test(viewer): async_states SkeletonLayout proptest surface (WBS-6.2 #458)#473KooshaPari wants to merge 4 commits into
Conversation
Adds crates/sl-viewer/tests/properties_viewer_help_overlay.rs with 13 proptest properties pinning the keyboard help SSOT: * SHORTCUTS is non-empty. * Every shortcut has non-empty keys / scope / action. * Every action is descriptive (has at least one ASCII letter) and human-readable (no ERR_ / error code leaks). * Every (keys, scope) pair is unique so the rendered table does not collide on its React key. * The ?, Escape, and Cmd+K / Ctrl+K shortcuts are present. * Every scope is one of the documented panel scopes. * Every keys is non-blank. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
Adds crates/sl-viewer/tests/properties_viewer_settings_tab.rs with 11 proptest properties pinning the settings tab SSOT: * HealthStatus::Unknown.label() is , Healthy is , Unreachable is . * Every label is non-empty, distinct across variants, single-line, and lowercase ASCII. * label() is deterministic across calls. * THEME_RADIO_GROUP_ID is non-empty, kebab-case ASCII, and distinct from FORGE_DB_HINT_STORAGE_KEY. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
Adds crates/sl-viewer/tests/properties_viewer_menu.rs with 5 proptest properties pinning the desktop menu id SSOT: * Every documented menu id (9 of them: ID_APP_ABOUT, ID_APP_SETTINGS, ID_FILE_RELOAD_DISCOVERY, ID_FILE_SETTINGS, ID_EDIT_FIND, ID_VIEW_RELOAD, ID_VIEW_TOGGLE_THEME, ID_VIEW_COMMAND_PALETTE, ID_HELP_TOGGLE) is non-empty. * Every id is kebab-case ASCII so muda / JS / serde round-trips are safe. * Every id carries the documented sl-viewer. prefix. * Every id is unique across the documented set. * The menu taxonomy has exactly 9 documented ids. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
) Adds crates/sl-viewer/tests/properties_viewer_async_states.rs with 7 proptest properties pinning the async_states SSOT: * SkeletonLayout::default() is Bundles. * SkeletonLayout exposes exactly three variants (Bundles, ListDetail, StreamFeed). * Every variant's Debug label is non-empty, single-line, and matches one of the documented names. * SkeletonLayout::default() matches the first arm in the match block in ContentSkeleton. * list_rows.clamp(3, 6) lands in [3, 6] for every input. * The clamp is monotonic non-decreasing. * The clamp has the documented fixed points (0/2 -> 3, 6/MAX -> 6). Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 12 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
|
Closing due to staleness. |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| //! Property evidence for sl-viewer's `async_states::SkeletonLayout` | ||
| //! enum and the `clamp_rows` helper used by `ContentSkeleton`. |
There was a problem hiding this comment.
Suggestion: The test claims to cover the production clamp_rows helper and the ContentSkeleton row behavior, but no clamp_rows helper exists and this code only evaluates the primitive usize::clamp directly. The property will remain green if ContentSkeleton stops clamping list_rows, clamps a different value, or uses different bounds. Test the production component/helper instead of duplicating the expression in the test. [api mismatch]
Severity Level: Major ⚠️
- ⚠️ Skeleton row regressions can pass tests.
- ⚠️ `ContentSkeleton` behavior is not exercised.
- ⚠️ Bounds changes lack production-level detection.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_async_states.rs
**Line:** 1:2
**Comment:**
*Api Mismatch: The test claims to cover the production `clamp_rows` helper and the `ContentSkeleton` row behavior, but no `clamp_rows` helper exists and this code only evaluates the primitive `usize::clamp` directly. The property will remain green if `ContentSkeleton` stops clamping `list_rows`, clamps a different value, or uses different bounds. Test the production component/helper instead of duplicating the expression in the test.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| /// forces a deliberate `default()` change. | ||
| #[test] | ||
| fn skeleton_layout_default_is_first_arm(_seed in any::<u32>()) { | ||
| let first = match () { |
There was a problem hiding this comment.
WARNING: skeleton_layout_default_is_first_arm is a tautology — it never verifies ContentSkeleton
The match () { () => SkeletonLayout::Bundles } always evaluates to Bundles regardless of input, so this test is a no-op duplicate of skeleton_layout_default_is_bundles. It claims to pin the first arm in ContentSkeleton but does not actually inspect that match block. If ContentSkeleton reorders arms or changes its default, this test will still pass.
Consider either:
- Removing this test (it adds no coverage beyond line 25), or
- Actually importing or referencing the production
ContentSkeletonmatch so the test fails when the first arm drifts.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| // appear under multiple scopes (e.g. `Escape` is a multi-scope | ||
| // close). We assert that at least one key appears more than once | ||
| // is reasonable; the strong check is the (keys, scope) pair. | ||
| let _ = (keys.len(), SHORTCUTS.len()); |
There was a problem hiding this comment.
WARNING: shortcuts_keys_unique is a dead test — no assertion is made
let _ = (keys.len(), SHORTCUTS.len()); computes and discards a tuple. The comment says "we assert that at least one key appears more than once is reasonable" but there is no prop_assert! or assert! here. This test will always pass, even if every keys value is duplicated or all are unique.
Replace the discard with an actual assertion, or remove the test if the (keys, scope) uniqueness check on line 82-90 is considered the strong check.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| } | ||
|
|
||
| /// The clamp has the documented fixed points: `0` and `2` clamp | ||
| /// to `3`; `6` and `u64::MAX` clamp to `6`. |
There was a problem hiding this comment.
SUGGESTION: Comment says u64::MAX but test uses usize::MAX
The doc comment documents the fixed point as u64::MAX, while line 101 asserts usize::MAX.clamp(3, 6) == 6. On 32-bit targets usize::MAX is u32::MAX, not u64::MAX, so the comment is misleading.
Update the comment to match the actual code, e.g. usize::MAX.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 67.5K · Output: 7.5K · Cached: 342.3K |
Shards the unique viewer proptest from #492 onto main without the obsolete pre-rename daemon source churn.
User description
Summary
Adds
crates/sl-viewer/tests/properties_viewer_async_states.rswith 7 proptest properties pinning theasync_states::SkeletonLayoutenum andlist_rows.clamp(3, 6)SSOT (WBS-6.2 #458).SkeletonLayout(4 properties)SkeletonLayout::default()isBundles.SkeletonLayoutexposes exactly three variants (Bundles,ListDetail,StreamFeed).Debuglabel is non-empty, single-line, and matches one of the documented names.SkeletonLayout::default()matches the first arm in thematchblock inContentSkeleton.list_rows.clamp(3, 6)(3 properties)[3, 6]for every input.0/2→3,6/usize::MAX→6).Validation
cargo test -p sl-viewer --test properties_viewer_async_states --features "desktop parquet" --locked— 7 passedcargo fmt --all --check— cleanWBS / TRACEABILITY
WBS-6.2 evidence list and
TRACEABILITY.jsongaincrates/sl-viewer/tests/properties_viewer_async_states.rs. CHANGELOG Unreleased documents the new surface.CodeAnt-AI Description
Add property coverage for key viewer interaction and loading-state contracts
What Changed
Impact
✅ Fewer broken help-overlay shortcuts✅ Clearer health-status labels✅ Fewer menu and DOM identifier collisions💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.