Repository navigation
fix(kimi): restore release-spliced executor - #669
KooshaPari wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 37 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Note
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
L17 Latency Budget ReportChecked against: budgets/rest-endpoints.yaml. |
L17 Latency Regression ReportThreshold: 10% p99 regression. |
|
|
Closing: unable to merge during cleanup. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e6a535171
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const prompt = foldMessages(messages); | ||
| const reqBody = this.buildRequestBody(prompt, wantThinking); | ||
| const reqBody = this.buildRequestBody(prompt, wantThinking, modelConfig.scenario); |
There was a problem hiding this comment.
Pass the folded prompt strings into the request
For every request, foldMessages() now returns { prompt, systemPrompt }, but this passes that object directly to buildRequestBody(), which places it in message.blocks[0].text.content where Kimi expects a string. Consequently ordinary requests produce a malformed Connect payload, and system/developer instructions are never transmitted in a dedicated field. Destructure the folded result and put each string in its expected wire location.
Useful? React with 👍 / 👎.
| export function resolveModelConfig(modelId: string): KimiModelConfig { | ||
| if (modelId === "k2d6-thinking") return { scenario: "SCENARIO_K2D5", thinking: true }; | ||
| // `k2d6` (Instant) and any unknown id fall back to the default chat scenario. | ||
| return { scenario: "SCENARIO_K2D5", thinking: false }; |
There was a problem hiding this comment.
Resolve the actual curated Kimi model IDs
When callers select the curated k3 model, this helper falls through to SCENARIO_K2D5, even though open-sse/config/providers/registry/kimi/web/runtime.ts maps k3 to SCENARIO_OK_COMPUTER with kimiPlusId: "ok-computer". The resulting request is shaped as a K2.6 chat instead of a K3 agent request and can be rejected or routed incorrectly; use the imported runtime model configuration rather than this fallback-only mapping.
Useful? React with 👍 / 👎.


Summary
4e0fc462e9Validation
encoderdeclaration and unexpectedcatchnpx esbuild open-sse/executors/kimi-web.ts --outfile=/tmp/omniroute-kimi-web.js --format=esm --log-level=errornpx prettier --check open-sse/executors/kimi-web.tsnpx eslint open-sse/executors/kimi-web.tsgit diff --checkDependency boundary
The focused Kimi test suites now reach the missing provider registry factory addressed independently in PR #666. The unchanged decoder test is already non-Prettier-compliant on main.