Skip to content

fix(kimi): restore release-spliced executor - #669

Closed
KooshaPari wants to merge 1 commit into
mainfrom
fix/kimi-web-release-splice-restore-20260820
Closed

KooshaPari wants to merge 1 commit into
mainfrom
fix/kimi-web-release-splice-restore-20260820

Conversation

@KooshaPari

Copy link
Copy Markdown
Owner

Summary

  • restore the coherent Kimi Web Connect-frame completion path removed by release commit 4e0fc462e9
  • eliminate the orphaned parser fragment that made the production executor unbundleable

Validation

  • RED: Esbuild reported duplicate encoder declaration and unexpected catch
  • GREEN: npx esbuild open-sse/executors/kimi-web.ts --outfile=/tmp/omniroute-kimi-web.js --format=esm --log-level=error
  • npx prettier --check open-sse/executors/kimi-web.ts
  • npx eslint open-sse/executors/kimi-web.ts
  • git diff --check

Dependency boundary

The focused Kimi test suites now reach the missing provider registry factory addressed independently in PR #666. The unchanged decoder test is already non-Prettier-compliant on main.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@KooshaPari, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c2331e47-5c67-4f15-a9e6-e3909180cb4c

📥 Commits

Reviewing files that changed from the base of the PR and between dc22b8e and 1e6a535.

📒 Files selected for processing (2)
  • docs/sessions/20260719-cross-chat-alignment/HANDOFFS.md
  • open-sse/executors/kimi-web.ts

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "review"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

Copy link
Copy Markdown

L17 Latency Budget Report

--- Latency Budget Summary ---
  Total endpoints checked: 0
  Passed: 0
  Warnings: 0
  Failures: 0

Checked against: budgets/rest-endpoints.yaml.

@github-actions

Copy link
Copy Markdown

L17 Latency Regression Report

No trace file available — cannot compute regression

Threshold: 10% p99 regression.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@KooshaPari
KooshaPari marked this pull request as ready for review August 22, 2026 01:34
Copilot AI lite review requested due to automatic review settings August 22, 2026 01:34
@KooshaPari

Copy link
Copy Markdown
Owner Author

Closing: unable to merge during cleanup.

@KooshaPari KooshaPari closed this Aug 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e6a535171

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 318 to +319
const prompt = foldMessages(messages);
const reqBody = this.buildRequestBody(prompt, wantThinking);
const reqBody = this.buildRequestBody(prompt, wantThinking, modelConfig.scenario);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pass the folded prompt strings into the request

For every request, foldMessages() now returns { prompt, systemPrompt }, but this passes that object directly to buildRequestBody(), which places it in message.blocks[0].text.content where Kimi expects a string. Consequently ordinary requests produce a malformed Connect payload, and system/developer instructions are never transmitted in a dedicated field. Destructure the folded result and put each string in its expected wire location.

Useful? React with 👍 / 👎.

Comment on lines +59 to +62
export function resolveModelConfig(modelId: string): KimiModelConfig {
if (modelId === "k2d6-thinking") return { scenario: "SCENARIO_K2D5", thinking: true };
// `k2d6` (Instant) and any unknown id fall back to the default chat scenario.
return { scenario: "SCENARIO_K2D5", thinking: false };

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve the actual curated Kimi model IDs

When callers select the curated k3 model, this helper falls through to SCENARIO_K2D5, even though open-sse/config/providers/registry/kimi/web/runtime.ts maps k3 to SCENARIO_OK_COMPUTER with kimiPlusId: "ok-computer". The resulting request is shaped as a K2.6 chat instead of a K3 agent request and can be rejected or routed incorrectly; use the imported runtime model configuration rather than this fallback-only mapping.

Useful? React with 👍 / 👎.

@KooshaPari
KooshaPari deleted the fix/kimi-web-release-splice-restore-20260820 branch August 22, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants