Skip to content

chore(omr): revert 12 direct-to-main SSE refactor bypasses - #662

Closed
KooshaPari wants to merge 1 commit into
mainfrom
chore/revert-sse-direct-to-main-12-bypasses
Closed

KooshaPari wants to merge 1 commit into
mainfrom
chore/revert-sse-direct-to-main-12-bypasses

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 19, 2026 •

Copy link
Copy Markdown
Owner

User description

Reverts 12 commits that bypassed PR review

These 12 merge commits (PR-α through PR-μ) all show 'on fork-main' in their subject but were added directly to main via force-push without going through GitHub's PR review process. They all claim to reference PRs (cheaper-inference#5223, cheaper-inference#8622, #555, etc.) — but those PRs do not exist on this repo.

The original fork-main branch was force-pushed to main bypassing required CI checks (the SSE refactor work was made directly on main under committer KooshaPari). This subsequent revert PR restores the codebase to the pre-bypass state (commit 9f8247e / PR #661 which is the last known-good commit before the SSE bypasses began).

After this PR merges, the SSE refactor work from these 12 commits will need to be re-submitted as proper PRs through the normal review pipeline.

**Ref:

Cc: @KooshaPari/collaborators


CodeAnt-AI Description

Remove the fork-module metadata and manual chat-state polling APIs

What Changed

  • Removes the API for listing fork-specific modules and their exports
  • Removes module summary reporting and the manual chat-state polling helper
  • Removes the associated tests for module metadata, summaries, and polling behavior

Impact

✅ Fewer exposed fork-specific introspection APIs
✅ No manual polling callbacks for fork chat state
✅ Existing chat-state formatting remains available

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Refactor
    • Removed obsolete fork-state metadata and summary handling.
    • Removed manual fork-state polling and listener APIs.
    • Deleted outdated automated tests covering the removed behavior.

Copilot AI lite review requested due to automatic review settings August 19, 2026 11:18
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@codeant-ai

codeant-ai Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 179f9d6 Aug 19, 2026 · 11:18 11:19

@codeant-ai

codeant-ai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "review"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f88380fb-a168-4a42-81ef-ada327131ca1

📥 Commits

Reviewing files that changed from the base of the PR and between 9f8247e and 179f9d6.

📒 Files selected for processing (2)
  • src/sse/handlers/__tests__/chatForkState.modules.test.ts
  • src/sse/handlers/chatForkState.ts

📝 Walkthrough

Walkthrough

The change removes fork-module metadata and summary APIs, manual fork-state polling APIs, and the test file that covered these interfaces.

Changes

Fork state API cleanup

Layer / File(s) Summary
Remove fork state metadata and polling APIs
src/sse/handlers/chatForkState.ts, src/sse/handlers/__tests__/chatForkState.modules.test.ts
Removes the fork-module registry, metadata and summary types, summary helper, listener and poller contracts, and manual polling function. Deletes the related tests.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/revert-sse-direct-to-main-12-bypasses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KooshaPari KooshaPari closed this Aug 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

Copy link
Copy Markdown

L17 Latency Regression Report

No trace file available — cannot compute regression

Threshold: 10% p99 regression.

@github-actions

Copy link
Copy Markdown

L17 Latency Budget Report

--- Latency Budget Summary ---
  Total endpoints checked: 0
  Passed: 0
  Warnings: 0
  Failures: 0

Checked against: budgets/rest-endpoints.yaml.

@kilo-code-bot

kilo-code-bot Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • src/sse/handlers/__tests__/chatForkState.modules.test.ts - Deleted (238 lines)
  • src/sse/handlers/chatForkState.ts - 137 lines removed

Analysis

This PR reverts 12 commits that were force-pushed directly to main bypassing the required PR review process. The specific changes in this diff remove:

  • ForkModuleMetadata, FORK_MODULES, ForkModuleSummary, summarizeForkModules()
  • ForkStateListener, ForkStatePoller, pollForkChatState()
  • Associated tests in chatForkState.modules.test.ts

Verification:

  • Zero references to deleted exports (FORK_MODULES, summarizeForkModules, pollForkChatState, etc.) found anywhere in the codebase.
  • Remaining test files (chatForkState.test.ts, chatForkState.diff.test.ts) only import surviving exports from chatForkState.ts.
  • No compilation or runtime breakage risk from these deletions.

The remaining chatForkState.ts exports (getForkChatState, diffForkChatStates, formatForkChatStateForCli) are unaffected and self-contained.


Fix these issues in Kilo Cloud


Reviewed by free · Input: 71K · Output: 3.2K · Cached: 288.3K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants