Skip to content

fix(ci): provision Trunk workflow lint dependencies - #548

Merged
KooshaPari merged 10 commits into
mainfrom
fix/trunk-jq-yamllint-main-20260808
Aug 8, 2026
Merged

KooshaPari merged 10 commits into
mainfrom
fix/trunk-jq-yamllint-main-20260808

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 8, 2026 •

Copy link
Copy Markdown
Owner

User description

Summary

  • install jq and yamllint before the Trunk action runs
  • retain official actionlint provisioning and expose its location through GITHUB_PATH
  • make the workflow itself yamllint line-length clean

Validation

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/trunk-check.yml")'\n- yamllint .github/workflows/trunk-check.yml (two repository-policy warnings only)\n- actionlint .github/workflows/trunk-check.yml\n- git diff --check\n\nSupersedes the stale/conflicting CI provisioning work in fix(ci): provision jq and actionlint for trunk #544; no force-push or history rewrite.

CodeAnt-AI Description

Provision all dependencies required for workflow lint checks

What Changed

  • CI now installs jq and yamllint before Trunk runs
  • The workflow continues to provide actionlint and verifies all three linting tools are available
  • Dependency download errors now fail clearly instead of producing misleading missing-tool failures

Impact

✅ Fewer workflow lint failures
✅ Clearer CI dependency errors
✅ Reliable YAML and GitHub Actions validation

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Chores
    • Improved automated workflow validation by installing and verifying YAML and workflow linting tools.
    • Updated workflow action versioning and cache configuration for more reliable checks and scheduled maintenance.

Copilot AI lite review requested due to automatic review settings August 8, 2026 10:17
@codeant-ai

codeant-ai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 32ab720 Aug 08, 2026 · 10:17 10:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai

codeant-ai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

L17 Latency Budget Report

--- Latency Budget Summary ---
  Total endpoints checked: 0
  Passed: 0
  Warnings: 0
  Failures: 0

Checked against: budgets/rest-endpoints.yaml.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Aug 8, 2026
@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@KooshaPari, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 14b5ab0a-8293-42a1-af20-bd507e406258

📥 Commits

Reviewing files that changed from the base of the PR and between 32ab720 and b228209.

📒 Files selected for processing (5)
  • .github/workflows/trunk-check.yml
  • docs/sessions/20260719-cross-chat-alignment/HANDOFFS.md
  • scripts/build/assembleStandalone.mjs
  • tests/unit/build/assemble-standalone.test.ts
  • tests/unit/build/prepublish-method-guard.test.ts

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "review"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
📝 Walkthrough

Walkthrough

The Trunk workflow now installs and verifies jq, yamllint, and actionlint. It also separates checkout and Trunk cache-version comments from action declarations.

Changes

Trunk workflow updates

Layer / File(s) Summary
Workflow tool installation and verification
.github/workflows/trunk-check.yml
The workflow installs jq and yamllint, downloads actionlint, adds it to PATH, and verifies all three tools.
Action version comment separation
.github/workflows/trunk-check.yml
The workflow moves checkout and Trunk cache-version annotations to separate comments.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary CI workflow change.
Description check ✅ Passed The description explains the workflow changes and lists relevant validation commands, but it omits several template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/trunk-jq-yamllint-main-20260808

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread .github/workflows/trunk-check.yml Fixed
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

L17 Latency Regression Report

No trace file available — cannot compute regression

Threshold: 10% p99 regression.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/trunk-check.yml:
- Around line 42-51: Update the actionlint installation block around
actionlint_host/actionlint_url to fetch download-actionlint.bash from a full
immutable commit, pass an explicit actionlint release version instead of latest,
and verify the downloaded release artifact’s SHA256 checksum before extraction
or use. Preserve the existing installation path and GitHub PATH setup, and fail
the workflow on checksum mismatch.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f64b8fb-d585-407e-8a9f-19e2929a7bfd

📥 Commits

Reviewing files that changed from the base of the PR and between 9ced409 and 32ab720.

📒 Files selected for processing (1)
  • .github/workflows/trunk-check.yml

Comment thread .github/workflows/trunk-check.yml Outdated
@kilo-code-bot

kilo-code-bot Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • .github/workflows/trunk-check.yml - CI workflow provisioning (jq, yamllint, pinned actionlint with SHA-256, eslint PATH export)
  • docs/sessions/20260719-cross-chat-alignment/HANDOFFS.md - Handoff documentation
  • scripts/build/prepublish.ts - CJS require injection for HTTP method guard in standalone
  • scripts/build/assembleStandalone.mjs - CommonJS package.json creation when Next omits it
  • tests/unit/build/prepublish-method-guard.test.ts - Regression test for CJS guard injection
  • tests/unit/build/assemble-standalone.test.ts - Regression test for CommonJS package scope + sidecar parity
Previous Review Summaries (2 snapshots, latest commit 7d939ce)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 7d939ce)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • .github/workflows/trunk-check.yml - Added project lint dependency installation and PATH export
  • docs/sessions/20260719-cross-chat-alignment/HANDOFFS.md - Handoff documentation

Previous review (commit 25f62bc)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .github/workflows/trunk-check.yml - Actionlint pinned with SHA256 verification, jq/yamllint provisioning
  • scripts/build/prepublish.ts - ESM import injection fix for HTTP method guard
  • tests/unit/build/prepublish-method-guard.test.ts - Regression test for ESM injection pattern
  • docs/sessions/20260719-cross-chat-alignment/HANDOFFS.md - Handoff documentation

Reviewed by step-3.7-flash · Input: 104.7K · Output: 13.9K · Cached: 890.2K

@KooshaPari
KooshaPari merged commit 48bc26f into main Aug 8, 2026
30 of 35 checks passed
@KooshaPari
KooshaPari deleted the fix/trunk-jq-yamllint-main-20260808 branch August 8, 2026 23:46
@sonarqubecloud

sonarqubecloud Bot commented Aug 8, 2026

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants