Skip to content

refactor(executors): extract pure quota parsing from codex (1539→1427) - #271

Merged
KooshaPari merged 1 commit into
mainfrom
refactor/exec-codex-split
Jul 3, 2026
Merged

KooshaPari merged 1 commit into
mainfrom
refactor/exec-codex-split

Conversation

@KooshaPari

Copy link
Copy Markdown
Owner

Port of upstream diegosouzapw#5999.

Extracts pure quota parsing out of codex.ts into open-sse/executors/codex/quota.ts; host imports it back. No behavior change.

Files

  • open-sse/executors/codex.ts — host trimmed 1539→1427
  • open-sse/executors/codex/quota.ts — extracted pure leaf (new)
  • tests/unit/codex-executor-split.test.ts — split-boundary test (new)

Verification

  • npm run typecheck:core — clean
  • split test — 3/3 pass
  • npm run check:cycles — no cycles (343 files)

Port of upstream diegosouzapw#5999. Extracts pure quota parsing
into open-sse/executors/codex/quota.ts; the host imports it back. Adds a
split-boundary unit test.
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@KooshaPari, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3a505aba-95e4-4cb7-89f7-b2e9be23bd46

📥 Commits

Reviewing files that changed from the base of the PR and between abf8a98 and 1335639.

📒 Files selected for processing (3)
  • open-sse/executors/codex.ts
  • open-sse/executors/codex/quota.ts
  • tests/unit/codex-executor-split.test.ts

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "review"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/exec-codex-split

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

L17 Latency Regression Report

No trace file available — skipping latency regression comparison.

Threshold: 10% p99 regression.

@KooshaPari
KooshaPari merged commit e0894be into main Jul 3, 2026
66 of 72 checks passed
@KooshaPari
KooshaPari deleted the refactor/exec-codex-split branch July 3, 2026 06:10
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

L17 Latency Budget Report

--- Latency Budget Summary ---
  Total endpoints checked: 0
  Passed: 0
  Warnings: 0
  Failures: 0

Checked against: budgets/rest-endpoints.yaml.

@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@kilo-code-bot

kilo-code-bot Bot commented Jul 5, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: Merged PR - Post-merge Observations

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 1

WARNING: open-sse/executors/codex/quota.ts:39

parseFloat() returns NaN for non-numeric header values without validation. Malformed header values could cause silent logic errors in quota calculations.

SUGGESTION: tests/unit/codex-executor-split.test.ts:23

The regex /export (function|interface) ${sym}\\b/ matches CodexQuotaSnapshot but the word boundary may be fragile. Consider explicit patterns per symbol type.

Files Reviewed
  • open-sse/executors/codex.ts
  • open-sse/executors/codex/quota.ts
  • tests/unit/codex-executor-split.test.ts

Reviewed by laguna-m.1-20260312:free · Input: 175.5K · Output: 12.2K · Cached: 1M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant