refactor(executors): extract pure quota parsing from codex (1539→1427) - #271
Conversation
Port of upstream diegosouzapw#5999. Extracts pure quota parsing into open-sse/executors/codex/quota.ts; the host imports it back. Adds a split-boundary unit test.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Note
|
L17 Latency Regression ReportThreshold: 10% p99 regression. |
L17 Latency Budget ReportChecked against: budgets/rest-endpoints.yaml. |
|
Code Review SummaryStatus: Merged PR - Post-merge Observations Overview
WARNING: open-sse/executors/codex/quota.ts:39parseFloat() returns NaN for non-numeric header values without validation. Malformed header values could cause silent logic errors in quota calculations. SUGGESTION: tests/unit/codex-executor-split.test.ts:23The regex Files Reviewed
Reviewed by laguna-m.1-20260312:free · Input: 175.5K · Output: 12.2K · Cached: 1M |



Port of upstream diegosouzapw#5999.
Extracts pure quota parsing out of
codex.tsintoopen-sse/executors/codex/quota.ts; host imports it back. No behavior change.Files
open-sse/executors/codex.ts— host trimmed 1539→1427open-sse/executors/codex/quota.ts— extracted pure leaf (new)tests/unit/codex-executor-split.test.ts— split-boundary test (new)Verification
npm run typecheck:core— cleannpm run check:cycles— no cycles (343 files)