Skip to content

feat: port upstream bundle D — dashboard error fix + i18n browser locale auto-detect - #235

Merged
KooshaPari merged 2 commits into
mainfrom
port/bundle-d
Jul 3, 2026
Merged

KooshaPari merged 2 commits into
mainfrom
port/bundle-d

Conversation

@KooshaPari

Copy link
Copy Markdown
Owner

Ports diegosouzapw#6028 diegosouzapw#5979

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jul 3, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@KooshaPari, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 36e565d0-bb53-4d22-991b-1d4fcb856472

📥 Commits

Reviewing files that changed from the base of the PR and between 72fdb48 and 74c9e71.

📒 Files selected for processing (9)
  • CHANGELOG.md
  • src/app/(dashboard)/dashboard/HomePageClient.tsx
  • src/app/layout.tsx
  • src/i18n/detectBrowserLocale.ts
  • src/shared/components/LanguageSelector.tsx
  • src/shared/components/LocaleAutoDetect.tsx
  • src/shared/lib/persistLocale.ts
  • tests/unit/i18n-detect-browser-locale.test.ts
  • tests/unit/ui/home-update-error-render.test.ts

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "review"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch port/bundle-d

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a3a97c76c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +44 to +45
const prefix = language.split("-")[0];
const prefixIndex = normalizedLocales.indexOf(prefix);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match primary tags to regional locales

When a supported locale is regional without a bare-language entry, this lookup fails the new first-visit detection path. The live locale list includes uk-UA and zh-CN but not uk or zh (config/i18n.json), so common browser values like uk or zh-Hans-CN fall through to null instead of selecting the available Ukrainian/Simplified Chinese UI, leaving those users on the default locale despite a supported translation being present. Consider also matching supported locales whose primary subtag equals prefix when no bare locale exists.

Useful? React with 👍 / 👎.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

L17 Latency Budget Report

--- Latency Budget Summary ---
  Total endpoints checked: 0
  Passed: 0
  Warnings: 0
  Failures: 0

Checked against: budgets/rest-endpoints.yaml.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

L17 Latency Regression Report

No trace file available — skipping latency regression comparison.

Threshold: 10% p99 regression.

@KooshaPari
KooshaPari merged commit 0ae36fa into main Jul 3, 2026
66 of 71 checks passed
@KooshaPari
KooshaPari deleted the port/bundle-d branch July 3, 2026 04:05
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

KooshaPari added a commit that referenced this pull request Jul 3, 2026
… as text (diegosouzapw#5991) (#282)

The production fix (import + extractApiErrorMessage() in the Update-now handler)
already landed in the fork via #235; this ports the upstream diegosouzapw#6028 regression
guard tests/unit/ui/home-update-error-render-5991.test.ts that pins the invariant,
and records it in the CHANGELOG.

Co-authored-by: Diego Rodrigues de Sa e Souza <diegosouzapw@users.noreply.github.com>
@kilo-code-bot

kilo-code-bot Bot commented Jul 4, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Issue already documented in existing comment — consider for follow-up

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

The existing comment on src/i18n/detectBrowserLocale.ts:45 correctly identifies that regional locales (e.g., uk-UA, zh-CN) in the locale catalog are not matched by bare-language browser values (e.g., uk, zh). The current detectBrowserLocale function only matches:

  1. Exact locales (e.g., en-US → en fails, but en → en works)
  2. Prefixes of the browser language (e.g., en-US → en via prefix match)

But it does NOT match:

  • A bare browser language to a regional locale (e.g., uk → uk-UA fails)
  • Complex script tags (e.g., zh-Hans-CN → zh-CN fails)

This means users with browsers reporting simplified language codes may not get their preferred locale matched.

Files Reviewed (9 files)
  • src/i18n/detectBrowserLocale.ts - Valid concern documented in existing comment (regional locale matching)
  • src/shared/lib/persistLocale.ts - Clean shared utility function
  • src/shared/components/LocaleAutoDetect.tsx - Clean client component wrapper
  • src/shared/components/LanguageSelector.tsx - Clean refactoring
  • src/app/layout.tsx - Clean integration
  • tests/unit/i18n-detect-browser-locale.test.ts - Good test coverage
  • tests/unit/ui/home-update-error-render.test.ts - Good regression tests
  • src/app/(dashboard)/dashboard/HomePageClient.tsx - Clean error handling fix
  • CHANGELOG.md - Appropriate changelog entry

Reviewed by laguna-m.1-20260312:free · Input: 234K · Output: 5.5K · Cached: 887.5K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant