-
Notifications
You must be signed in to change notification settings - Fork 0
Phase 3: self-healing telemetry v2 (rolling z-score + typed playbooks) #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,6 +136,7 @@ export async function GET() { | |
| comboCooldownWait: resilience.comboCooldownWait, | ||
| quotaShareConcurrencyLimit: resilience.quotaShareConcurrencyLimit, | ||
| providerCooldown: resilience.providerCooldown, | ||
| selfHealing: resilience.selfHealing, | ||
| legacy: buildLegacyResilienceCompat(resilience), | ||
| }); | ||
| } catch (err: unknown) { | ||
|
|
@@ -208,6 +209,9 @@ export async function PATCH(request) { | |
| providerCooldown: body.providerCooldown as ResilienceSettingsPatch["providerCooldown"], | ||
| } | ||
| : {}), | ||
| ...(body.selfHealing | ||
| ? { selfHealing: body.selfHealing as ResilienceSettingsPatch["selfHealing"] } | ||
|
Comment on lines
+212
to
+213
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This Useful? React with 👍 / 👎. |
||
| : {}), | ||
| ...normalizeLegacyPatch(body), | ||
| }); | ||
|
|
||
|
|
@@ -244,6 +248,7 @@ export async function PATCH(request) { | |
| }, | ||
| comboCooldownWait: nextResilience.comboCooldownWait, | ||
| providerCooldown: nextResilience.providerCooldown, | ||
| selfHealing: nextResilience.selfHealing, | ||
| legacy: buildLegacyResilienceCompat(nextResilience), | ||
| }); | ||
| } catch (err: unknown) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields do not match the backend
SelfHealingSettingsshape (warnThreshold,criticalThreshold,minSamplesForDetection,retentionSeconds,playbookEnabled, etc.). As a result, the GET response renders values likezThreshold,cooloffMs,minSamples, anddryRunasundefined, and even after the PATCH schema is fixed the server normalizer will ignore those keys, so threshold/min-sample/dry-run edits will not persist or affect runtime behavior.Useful? React with 👍 / 👎.