feat(dashboard-renderer): stub out support for EntityLink [MA-2716] #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-peteu
commented
Mar 14, 2024
packages/analytics/dashboard-renderer/src/types/dashboard-renderer-types.ts
Show resolved
Hide resolved
mihai-peteu
commented
Mar 14, 2024
Comment on lines
3
to
12
| export default (routeParams: string[]): string => { | ||
| // TODO: may have to pass in geo from consuming app | ||
| const activeGeoCode = 'us' | ||
|
|
||
| const parsedRouteParams = routeParams.map(rp => rp.replace('{geo}', activeGeoCode)) | ||
|
|
||
| // TODO: replace `{idTuple0}` and `{idTuple1}` with actual record ID vales | ||
|
|
||
| return useExternalLinkCreator(parsedRouteParams) | ||
| } |
There was a problem hiding this comment.
if this isn't going to be shared amongst other charts in the dashboard, the logic could all be stashed inside generateEntityUrl in TopNTableRenderer most likely.
There was a problem hiding this comment.
We don't need use external link creator here
The host app is supposed to do this, the host app supplies the output of external link creator to the dashboard and the renderer replaces the appropriate ids
mihai-peteu
commented
Mar 14, 2024
| import type { AnalyticsExploreRecord, DisplayBlob, ExploreResultV4, QueryResponseMeta } from '@kong-ui-public/analytics-utilities' | ||
| import type { AnalyticsChartColors, SimpleChartOptions } from '../../src/types' | ||
| import { SeededRandom } from '../utils/SeedRandom' |
There was a problem hiding this comment.
@filipgutica this is my fault, I forgot to update the import in a previous PR 😬 Without this fix, the SimpleChart demo doesn't load.
filipgutica
force-pushed
the
feat/ma-2716-slottable-links-topn
branch
from
13a1ff3 to
921c516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/MA-2716
Resources