-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dep): group update k8s.io to v0.30.0 and controller-runtime to v0.18.2 #5935
Conversation
3ed21ed
to
0bdef84
Compare
… v0.18.2 Signed-off-by: Jintao Zhang <[email protected]>
0bdef84
to
1b8531e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5935 +/- ##
=======================================
+ Coverage 72.3% 74.0% +1.6%
=======================================
Files 181 182 +1
Lines 18473 18344 -129
=======================================
+ Hits 13363 13580 +217
+ Misses 4115 3826 -289
+ Partials 995 938 -57 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
5546d9f
to
4255e66
Compare
What this PR does / why we need it:
Which issue this PR fixes:
Special notes for your reviewer:
Q: Why bump controller-runtime to v0.18.x in this PR?
A: ref: kubernetes-sigs/controller-runtime#2788 If we bump client-go to v0.30.0, it will cause
go vet
error.Q: Why change it to Builder-style instead of using the Typed-handler?
A: As Typed Handlers are marked as experimental, I do not want to introduce experimental features into KIC at this time.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:- [ ] theCHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR