chore(ci): remove redundant ${{ ... }} in if statements in workflows

[programmer04]

What this PR does / why we need it:

When you use expressions in an if conditional, you may omit the ${{ ... }} expression syntax because GitHub Actions automatically evaluates the if conditional as an expression. Read more. I found a corner case where such omit is not applicable, e.g.

kubernetes-ingress-controller/.github/workflows/_e2e_tests.yaml

Line 81 in b6770b6

if: ${{ !cancelled() }}

read more here.

Issue created in GH docs github/docs#27497

[randmonkey]

Are all the remaining ${{ }} s are necessary?

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.1% ⚠️

Comparison is base (c397107) 67.7% compared to head (b6770b6) 67.7%.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #4517     +/-   ##
=======================================
- Coverage   67.7%   67.7%   -0.1%     
=======================================
  Files        161     161             
  Lines      18845   18845             
=======================================
- Hits       12769   12761      -8     
- Misses      5315    5326     +11     
+ Partials     761     758      -3     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[programmer04]

I think so @randmonkey only in if statements (with a caveat) they can be omitted

[pmalek]

@programmer04 Are we still working on this 🤔 ?

[programmer04]

I put it on hold @pmalek because I discovered a quick that I wanted to clarify github/docs#27497. Now knowing that I lean towards putting ${{ }} always in if 😛

[programmer04]

Since omitting doesn't work always (see official docs) I'm not longer advocating for adjusting it