fix: allow grpcs and tls for client_certificate #9270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
force-pushed
the
shaneutt/grpc-client-cert-blocked
branch
from
2191eed
to
1187be1
Compare
|
I could use some help in verifying this solution according to the problem that was seen in Kong/kubernetes-ingress-controller#2831. |
flrgh
force-pushed
the
shaneutt/grpc-client-cert-blocked
branch
from
1187be1
to
e84ed94
Compare
flrgh
requested changes
Oct 28, 2022
There was a problem hiding this comment.
The schema change looks correct to me 👍 @shaneutt can you please rebase and add a tests for the grpc and tls use cases? These types of connections/requests are handled very differently from regular https requests within Kong (and nginx for that matter), so I'm not 100% certain they will work without requiring any other code changes.
|
Thanks @flrgh 👍 I'm going to temporarily close this, as in the time since I originally made this PR I've changed teams. The intention right now is that someone from my previous team will be picking this back up in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A discussion in kong/kubernetes-ingress-controller wherein a user was trying to use mTLS with gRPC indicated a bug in the Kong Gateway where
grpcswasn't allowed to have aclient_certificate, this PR attempts to fix that (and also addtlswhile we're at it for similar reasons).Full changelog
grpcsandtlscould not be used withclient_certificatein servicesIssue reference
Fix for Kong/kubernetes-ingress-controller#2831