Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [AG-113] Gemini transformer plugins, incorrect URL and response error parsers #13703

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tysoekong
Copy link
Contributor

@tysoekong tysoekong commented Sep 23, 2024

Summary

This fixes two related issues:

  1. 'Gemini' when using a 'Google One' or 'Personal' subscription, was not forming the AI Transformer URL correctly, and resulted in all 404's
  2. 'from_format' parser error handling was using the wrong return argument, resulting in expected #1 got nil errors to the client

Checklist

Issue reference

AG-113

@tysoekong tysoekong added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee backport release/3.8.x labels Sep 23, 2024
@tysoekong tysoekong marked this pull request as ready for review September 23, 2024 14:50
@tysoekong tysoekong force-pushed the fix/AG-113_gemini_transformer_plugins branch from 9bc1685 to 063c199 Compare September 23, 2024 14:52
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 23, 2024
@tysoekong tysoekong force-pushed the fix/AG-113_gemini_transformer_plugins branch 2 times, most recently from be58eca to f9b5367 Compare September 27, 2024 13:49
@tysoekong tysoekong force-pushed the fix/AG-113_gemini_transformer_plugins branch from f9b5367 to 3ee4797 Compare September 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants