[DO NOT MERGE] Test aws init refactor #11570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/aws-lambda
core/db
chore
windmgc
force-pushed
the
test-aws-init-refactor
branch
from
dfeabd6
to
f01d8f0
Compare
…ntial provider (#11551) This PR contains a fix to let aws-lambda plugin-level proxy configuration take effect when fetching IAM credentials in an EKS environment. The EKS IRSA credential provider(aka TokenFileWebIdentityCredentials) will fire a request to AWS STS service when fetching the credential, and the request itself may need to go through the plugin-level proxy configuration. Here we check if a proxy is configured and whether the plugin is running inside the EKS environment with IRSA related configuration provided, then we replace the provider with a new TokenFileWebIdentityCredentials that supports proxy. FTI-5242
A worker singleton is a worker-global variable that is initialized only once. The get_worker_singleton function is used to access a worker singleton by name. It makes sure that when the variable is not yet initialized and multiple coroutines try to access it, only one calls the initialization functions and other coroutines wait. If get_worker_singleton is called in the init_worker phase, initialization is performed by the first call without locking as there are no other coroutines yet.
The init() function added in ea85db8 was perceived to have too little overall value. It is thus removed.
windmgc
force-pushed
the
test-aws-init-refactor
branch
from
c6c0d14
to
206a023
Compare
windmgc
changed the base branch from
master
to
test-aws-init-refactor-fake-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Need to debug a weird test failure
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdFull changelog
Issue reference
Fix #[issue number]