-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cancel button #92
Conversation
Instead of using a flag to stop the solver from within, is it maybe possible to just kill the solver's webworker/thread? |
I'd be very wary of killing threads or doing anything super unsafe like that; you'd be leaving a lot of memory leaks.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the web version doesn't compile. cloudflare-deploy.sh
needs to be able to run without errors.
Should build and work fine, but the web version's Cancel button doesn't actually work since the worker can't process the cancel message (single threaded behavior and all that). Been kind of stumped on that one for a few hours. |
It's fine if cancelling doesn't work for the web version. Can you make it so that the cancel button is not visible for web? |
Only issue I have with this implementation so far is the number of .is_set() checks done. I use an
unlikely
call to make sure it affects performance as little as possible, but you might have a better idea of where to strategically put these checks.