Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cancel button #92

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Add Cancel button #92

merged 4 commits into from
Nov 28, 2024

Conversation

WorkingRobot
Copy link

Only issue I have with this implementation so far is the number of .is_set() checks done. I use an unlikely call to make sure it affects performance as little as possible, but you might have a better idea of where to strategically put these checks.

@KonaeAkira
Copy link
Owner

Instead of using a flag to stop the solver from within, is it maybe possible to just kill the solver's webworker/thread?

@WorkingRobot
Copy link
Author

WorkingRobot commented Nov 27, 2024 via email

Copy link
Owner

@KonaeAkira KonaeAkira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the web version doesn't compile. cloudflare-deploy.sh needs to be able to run without errors.

solvers/src/macro_solver/solver.rs Outdated Show resolved Hide resolved
solvers/src/quality_upper_bound_solver/solver.rs Outdated Show resolved Hide resolved
solvers/src/macro_solver/solver.rs Outdated Show resolved Hide resolved
solvers/src/step_lower_bound_solver/solver.rs Outdated Show resolved Hide resolved
src/app.rs Show resolved Hide resolved
@WorkingRobot
Copy link
Author

WorkingRobot commented Nov 28, 2024

Should build and work fine, but the web version's Cancel button doesn't actually work since the worker can't process the cancel message (single threaded behavior and all that). Been kind of stumped on that one for a few hours.

@KonaeAkira
Copy link
Owner

It's fine if cancelling doesn't work for the web version. Can you make it so that the cancel button is not visible for web?

@KonaeAkira KonaeAkira self-requested a review November 28, 2024 19:56
src/app.rs Outdated Show resolved Hide resolved
@KonaeAkira KonaeAkira merged commit 1070113 into KonaeAkira:preview Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants