Skip to content

Conversation

@jmjatlanta
Copy link

This PR refactors the Jumblr code for

  • better string handling
  • better documentation
  • no reliance on globals

Now, the Jumblr codebase is wrapped in a class. The object is a global for now, but is flexible and somewhat self-contained, so hopefully will not be a global in the future. Such changes should provide better maintainability and testability.

The constructor takes the KMDUSERPASS and port (formerly the BITCOIND_RPCPORT global).

@jmjatlanta
Copy link
Author

In my opinion: Remove this code from the core daemon, and keep it in some "interesting tech" branch.

Modification of this code should probably be relegated to some research branch instead of dev IMO ( I believe @dimxy agrees). Such code (and their changes) should not be a focus for core "komodod", as technologies such as Jumblr aren't a focus of the core chain.

@dimxy
Copy link
Collaborator

dimxy commented Jul 29, 2022

looks like this PR should be closed and jumblr code is rremoved in PR #551

@tonymorony
Copy link

these changes implemented in combined PR: #559

@tonymorony tonymorony closed this Sep 5, 2022
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants