Add ChainParams to Assetchains #511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The Bitcoin code base has moved to a similar concept. As they are further along than this is (a bit more "proven"), I'd like to use what they have. See https://github.com/bitcoin/bitcoin/blob/d3582f2d3bfebb32316aa3974f6f27db20a610f5/src/node/context.h#L39 |
Author
|
Closing in favor of following bitcoin's newer model of NodeContext |
who-biz
pushed a commit
to who-biz/komodo
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental step in getting the assetchain object to hold state that used to be for globals. See #509
This PR moves the formerly global object that was pointed to by the Params() method to within the assetchain class. This means that more than one instance of ChainParams can exist if more than one assetchain object exists. This has implications for modularity and testing.
As was stated in #509, this PR could be merged directly to
devor reviews could be done incrementally by reviewing/merging 507, then 509, then this one.