-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement debug builds for windows #2219
Conversation
Defer testing until #2221 merged into dev |
Debug build fails to run with: Release build works just fine. |
Cheers - I'll check it later for 0.5.8 as it is not a critical fix and we only need release binaries for 0.5.7.1 |
windows builds with mm2 from the new CI are failing (http://54.170.62.22:8000/dev/mm2_759d180-win-x86-64.zip)
those files were included in the mm2 zip of the old CI, but are not included in the zip from new CI |
Does the mm2 zip run ok in command line? |
idk, i don't have any windows devices to try |
It built ok in https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/4342695465/attempts/1 |
windows built with mm2 from new CI: https://github.com/cipig/atomicDEX-Desktop/actions/runs/4531698392/jobs/7982212673 |
CI was missing a variable for the windows matrix.
To test: