Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Cache some deps #2190

Merged
merged 20 commits into from
Jan 8, 2023
Merged

[CI] Cache some deps #2190

merged 20 commits into from
Jan 8, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 30, 2022 •
edited
Loading

Hopefully this will speed up CI builds.

Updated some actions to newer versions:

  • actions/checkout@v3
  • [email protected] (using upstream, will update our pinned repo if no issues)
  • run-vcpkg@v10
  • upload-artifact@v3

Updated Nim to 1.6.10 and updated deprecated Nim syntax.

@smk762 smk762 marked this pull request as draft January 1, 2023 11:27
@smk762
Copy link
Collaborator Author

smk762 commented Jan 2, 2023 •
edited by Canialon
Loading

@SirSevenG @Canialon please do a launch and smoke/swap test on the binaries from https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/3828496752 (release and debug, installer and portable)

I've updated some deps in our CI workflow and added some caching to try and shave a few minutes of each run (tho mac still takes longer than I'd like it to).

Comment and check off OS / build / binary pairs you have confirmed ok.

  • Windows, release, portable
  • Windows, release, installer
  • Windows, debug, portable
  • Windows, debug, installer
  • Mac, release, portable
  • Mac, release, installer
  • Mac, debug, portable
  • Mac, debug, installer
  • Linux, release, portable
  • Linux, release, installer
  • Linux, debug, portable
  • Linux, debug, installer

@smk762 smk762 marked this pull request as ready for review January 3, 2023 16:07
cipig
cipig approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs fine on Linux

SirSevenG
SirSevenG approved these changes Jan 5, 2023
View reviewed changes
Copy link

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Win11 and macOS, all builds passed the smoke test.

@smk762 smk762 merged commit be59dda into dev Jan 8, 2023
@smk762 smk762 deleted the cache-CI-deps branch January 8, 2023 08:42
@smk762 smk762 mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canialon Canialon Canialon approved these changes

@SirSevenG SirSevenG SirSevenG approved these changes

@cipig cipig cipig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smk762 @cipig @SirSevenG @Canialon