Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish Translations #2010

Merged
merged 4 commits into from
Oct 25, 2022
Merged

Add Spanish Translations #2010

merged 4 commits into from
Oct 25, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Oct 17, 2022

Thanks to PTYX for assisting with initial spreadsheet translation input.
PR includes a script to convert translations csv file to .ts file. The output covers 98% of what is required, with a little manual post-processing needed to cater for numerusform entries.

@tonymorony tonymorony marked this pull request as draft October 17, 2022 21:00
@tonymorony
Copy link

@smk762 this PR contains not related changes

@smk762
Copy link
Collaborator Author

smk762 commented Oct 18, 2022

@smk762 this PR contains not related changes

removed

@smk762 smk762 marked this pull request as ready for review October 24, 2022 12:22
@smk762 smk762 requested review from a user and tonymorony October 24, 2022 12:22
@tonymorony
Copy link

in general lgtm so merging - if fixes will be needed we can fix it separately

@tonymorony tonymorony merged commit 22cd5d9 into dev Oct 25, 2022
@smk762 smk762 mentioned this pull request Nov 18, 2022
@smk762 smk762 changed the title Add Spanish Add Spanish Translations Nov 18, 2022
@smk762 smk762 deleted the espanol branch August 7, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants