-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vertical resizing feature to Widget component #1886
Conversation
Still in draft - ready to test? If so what's the best way to test? |
Not ready for testing, still buggy |
rdy @smk762 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't expand to full height when you resize the window ? @cipig |
It does, but it doesn't if you make only orderbook smaller |
Yeah it's like that beause the height is bind to your window's height by default - so if you change manually the size of your widget, it's not bind anymore to the window's height Please note if you also resize the window and if the widgets are too long for the current window size, their height should be automatically reset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^
Reset children height to minimum height when expanding one child if there is not enough space inside the widget container
Closes #1733