Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical resizing feature to Widget component #1886

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2022

Closes #1733

@ghost ghost requested a review from smk762 July 25, 2022 10:52
@smk762
Copy link
Collaborator

smk762 commented Jul 25, 2022

Still in draft - ready to test? If so what's the best way to test?

@ghost
Copy link
Author

ghost commented Jul 25, 2022

Still in draft - ready to test? If so what's the best way to test?

Not ready for testing, still buggy
I'll complete the PR once it's ready

@ghost ghost marked this pull request as ready for review August 1, 2022 13:51
@ghost
Copy link
Author

ghost commented Aug 1, 2022

rdy @smk762

@ghost ghost requested review from tonymorony and cipig August 1, 2022 13:52
cipig
cipig previously approved these changes Aug 1, 2022
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you make orderbook smaller, "best orders" does not expand to full height automatically
image
but idk if that is important, works as expected else

@ghost
Copy link
Author

ghost commented Aug 2, 2022

if you make orderbook smaller, "best orders" does not expand to full height automatically image but idk if that is important, works as expected else

It doesn't expand to full height when you resize the window ? @cipig

@cipig
Copy link
Member

cipig commented Aug 2, 2022

It doesn't expand to full height when you resize the window ? @cipig

It does, but it doesn't if you make only orderbook smaller
oh, and it does too when you change resize window afterwards

@ghost
Copy link
Author

ghost commented Aug 2, 2022

It doesn't expand to full height when you resize the window ? @cipig

It does, but it doesn't if you make only orderbook smaller oh, and it does too when you change resize window afterwards

Yeah it's like that beause the height is bind to your window's height by default - so if you change manually the size of your widget, it's not bind anymore to the window's height

Please note if you also resize the window and if the widgets are too long for the current window size, their height should be automatically reset

@tonymorony
Copy link

right now it's possible to minimise widgets to such state, what is imo not cool

It would be great to assign minimal size for every widget (e.g. 2 bids/2asks min for orderbook, 2 orders for best orders)

image

Copy link

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

syl added 2 commits August 4, 2022 13:14
Reset children height to minimum height when expanding one child if there is not enough space inside the widget container
@ghost ghost requested review from tonymorony and cipig August 4, 2022 11:15
@ghost
Copy link
Author

ghost commented Aug 5, 2022

@tonymorony

@tonymorony tonymorony merged commit d441e4f into dev Aug 9, 2022
@smk762 smk762 mentioned this pull request Nov 18, 2022
@smk762 smk762 deleted the pro_trade_change_tab_sizing branch August 7, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: orderbook does not expand when resizing window
3 participants