Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong password error messaging #1723

Merged
2 commits merged into from
Apr 6, 2022
Merged

fix wrong password error messaging #1723

2 commits merged into from
Apr 6, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Apr 5, 2022

closes #1717

  • no more extraneous password errors
  • incorrect password message has static height to avoid dancing on display
  • error message disappears when text changes
  • error animation activates even when password char / length constrains are matched

@smk762 smk762 requested review from a user, tonymorony and Canialon April 5, 2022 02:03
field.onAccepted:
{
if (_keyChecker.isValid())
{
onClickedLogin(field.text)
if (!onClickedLogin(field.text)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brace on next line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@smk762 smk762 requested a review from a user April 5, 2022 11:37
Copy link

@Canialon Canialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly! thanks 😄

@ghost ghost merged commit 05969ae into dev Apr 6, 2022
@tonymorony tonymorony mentioned this pull request Jun 21, 2022
@ghost ghost deleted the login_pw_hinting branch September 15, 2022 10:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: password requirements on login page
2 participants