Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qt.settings.page.cpp #1331

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Update qt.settings.page.cpp #1331

merged 1 commit into from
Sep 24, 2021

Conversation

Milerius
Copy link

No description provided.

@tonymorony
Copy link

is it related to #1329 ?

@Milerius
Copy link
Author

is it related to #1329 ?

Yes! Did it from mobile sorry

@tonymorony
Copy link

thanks for the clarification @Milerius !

@smk762 test plan is custom ERC20/BEP20 tokens adding. it would be great to include this fix into 0.5.2 release

@smk762
Copy link
Collaborator

smk762 commented Sep 23, 2021

Should we add inputs for coinpaprika too? Is it needed for new pricing service?

@smk762
Copy link
Collaborator

smk762 commented Sep 23, 2021

Added custom ERC / QRC / BEP without error
image

Note: on restart and coin activating, parent chain does not activate (see image, no QTUM or BNB). User has to add them manually afterwards.

@Milerius
Copy link
Author

Note: on restart and coin activating, parent chain does not activate (see image, no QTUM or BNB). User has to add them manually afterwards.

This should be the case in the slp branch

@Milerius
Copy link
Author

Should we add inputs for coinpaprika too? Is it needed for new pricing service?

Custom tokens cannot have price anymore due to our new service, the new service is not aware of custom tokens.

@tonymorony tonymorony merged commit 2806095 into dev Sep 24, 2021
@smk762 smk762 deleted the Milerius-patch-2 branch November 7, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants