Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add full names to filter dropdowns #1292

Merged
merged 2 commits into from
Sep 15, 2021
Merged

add full names to filter dropdowns #1292

merged 2 commits into from
Sep 15, 2021

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Sep 15, 2021

Fixes #1287
image

@smk762
Copy link
Collaborator Author

smk762 commented Sep 15, 2021

Would adding coin icon here be worth doing also?

@smk762 smk762 requested review from a user and tonymorony September 15, 2021 12:16
@tonymorony
Copy link

Would adding coin icon here be worth doing also?

I think it would be visual overkill to add an icon here

tonymorony
tonymorony approved these changes Sep 15, 2021
View reviewed changes
Copy link

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tonymorony tonymorony merged commit 43d7d03 into dev Sep 15, 2021
@tonymorony tonymorony deleted the tickername_filter branch September 15, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonymorony tonymorony tonymorony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Add coin name next to the ticker in filters
2 participants
@smk762 @tonymorony