-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(price_service): transition to komodo price service #1266
Conversation
…for the http call)
…ider and the last time update
* Add LastPriceTimestamp * Add PriceProvider
* Function's name is providerIcon()
* Add String.js file to the qrc, it must contain all string manipulation related functions * Add capitalizeFirstLetter in the String.js file
* Add a tooltip when hovering the icon which tells what is the provider
…ktop into komodo_price_service
Supernet assets shouldn't be availiable on simple trading view: Screen.Recording.2021-09-14.at.14.30.27.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^
yes :) (additional condition for wallet_only: true coins is needed I wonder) |
@SylEze @Milerius there is a conflict with dev atm
so CI not triggered |
…ktop into komodo_price_service
This pr introduce the komodo price service and replace the coingecko one
Everything related to price in general need to be tested