Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webengineview crash #1263

Merged
9 commits merged into from
Sep 14, 2021
Merged

Fix webengineview crash #1263

9 commits merged into from
Sep 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 9, 2021

Might close #1119
Might close #1248

@ghost ghost requested review from Milerius and smk762 September 9, 2021 15:49
@smk762
Copy link
Collaborator

smk762 commented Sep 10, 2021

Seeing this in logs for wallet chart -

[15:27:27] [warning] [main.prerequisites.hpp:92] [1003327]: qrc:/atomic_defi_design/qml/Wallet/Main.qml:516: ReferenceError: chart is not defined

Stuck on
image

No crash during tests (rapid change from wallet to DEX where selections both have chart) on Linux.

LMK how best to test this otherwise - Was this mostly an issue on M1 Macs? I cant cover that test case here.

@ghost
Copy link
Author

ghost commented Sep 10, 2021

Seeing this in logs for wallet chart -

[15:27:27] [warning] [main.prerequisites.hpp:92] [1003327]: qrc:/atomic_defi_design/qml/Wallet/Main.qml:516: ReferenceError: chart is not defined

Stuck on
image

No crash during tests (rapid change from wallet to DEX where selections both have chart) on Linux.

LMK how best to test this otherwise - Was this mostly an issue on M1 Macs? I cant cover that test case here.

Indeed it was mostly present on M1 Macs, but @Milerius told me that he was able to reproduce on Linux

@ghost ghost marked this pull request as ready for review September 10, 2021 09:10
@smk762
Copy link
Collaborator

smk762 commented Sep 10, 2021

No crashes detected here yet, seeing chart on wallet now.

Any chance we can avoid the white defualt white background flickering on change in dark mode (lite mode is ok)?
https://user-images.githubusercontent.com/35845239/132842890-bf190823-e5ba-499c-97f0-f817fc90d83c.mp4

@ghost
Copy link
Author

ghost commented Sep 10, 2021

No crashes detected here yet, seeing chart on wallet now.

Any chance we can avoid the white defualt white background flickering on change in dark mode (lite mode is ok)?
https://user-images.githubusercontent.com/35845239/132842890-bf190823-e5ba-499c-97f0-f817fc90d83c.mp4

Yeah sure, I can make the web view hidden until it's fully loaded

@smk762
Copy link
Collaborator

smk762 commented Sep 10, 2021

Just got a crash on Windows , logs attached.
2021-09-10-11-05-38.log

@smk762
Copy link
Collaborator

smk762 commented Sep 10, 2021

Just noticed that on wallet page, if switching to a different coin that has no chart (e.g. RICK/MORTY), the previously loaded chart is still displayed.
In earlier versions, it would display as below instead
image

@smk762
Copy link
Collaborator

smk762 commented Sep 10, 2021

On dex page if switching from pair with chart to pair without, can we extend the lower section?
image

vs
image

@ghost ghost merged commit 7b52793 into dev Sep 14, 2021
@smk762 smk762 deleted the fix_webengineview_crash branch November 7, 2021 13:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: QWebEngine view and loader may cause crashing [BUG]: Crash on MacOS (M1)
1 participant