fix(native-auth-ops): remove exceptions from logs in KDF restart function#45
fix(native-auth-ops): remove exceptions from logs in KDF restart function#45
Conversation
The `findExceptionsInLog` function called in the _restartKdf appears to be finding innocuous errors and re-throwing them. The one being caught on my machine is a socket connection error from an RPC, version, likely while KDF is starting or stopping. Rethrowing exceptions from logs seems out-of-place in the restart kdf function.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. See here for more details.
Files not reviewed (7)
- packages/komodo_defi_framework/app_build/build_config.json: Language not supported
- packages/komodo_defi_framework/lib/src/operations/kdf_operations_native.dart: Language not supported
- packages/komodo_defi_local_auth/lib/src/auth/auth_service_kdf_extension.dart: Language not supported
- packages/komodo_defi_sdk/example/ios/Runner.xcodeproj/project.pbxproj: Language not supported
- packages/komodo_defi_sdk/example/ios/Runner/Info.plist: Language not supported
- packages/komodo_defi_sdk/example/web/kdf/res/kdf_wrapper.dart: Language not supported
- packages/komodo_defi_types/lib/src/utils/security_utils.dart: Language not supported
WalkthroughThis pull request updates the system’s configuration and control flow in multiple areas. The build configuration now references a new commit hash for the bundled coins repository. The KDF operations have been modified to replace a fixed delay with a loop that checks for RPC server readiness and simplify error handling in the restart routine. In addition, placeholder properties were added to iOS build phases, UI keys were re-ordered in the Info.plist, a header comment was updated in a web resource, and the sensitive key list in security utilities was expanded. Changes
Sequence Diagram(s)sequenceDiagram
participant KDF as KDF Operation
participant RPC as RPC Server
KDF->>RPC: Check RPC status
alt Not ready
loop Up to 20 attempts
KDF->>RPC: Check RPC status (retry)
RPC-->>KDF: Status: not ready
end
KDF->>KDF: Log warning (if still not ready)
else Ready
RPC-->>KDF: Status: rpcIsUp
end
KDF->>KDF: Proceed with KDF operation
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
🔇 Additional comments (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Removes
findExceptionsInLogfrom the_restartKdffunction, which is re-throwing connection errors from RPCs like the one below. These errors are innocuous errors, usually seen while KDF is restarting during a login.Also adds logic to wait for the RPC to be up in native
kdfMainrather than a static 500ms delay.