build(kdf): bump KDF commit hash and checksums#210
Conversation
WalkthroughUpdated build_config.json to point to a new api_commit_hash and bundles_coins_repo_commit, and refreshed valid_zip_sha256_checksums for all listed platforms. No structural changes; only value updates to existing keys. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the KDF (Komodo DeFi Framework) build configuration to use a newer commit hash and corresponding SHA256 checksums. The update affects both the API commit reference and the bundled coins repository commit.
- Updates API commit hash to a newer version
- Updates SHA256 checksums for all platform-specific binary packages to match the new build
- Updates bundled coins repository commit hash
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/komodo_defi_framework/app_build/build_config.json (2)
3-3: Confirmed commit SHA and suggested Gitleaks allowlistVerified that commit 80766b0056062797c3c385b9d1497bb31ac00139 exists in KomodoPlatform/komodo-defi-framework and is reachable from the dev branch. The change to the
api_commit_hashfield is valid.To prevent future Gitleaks false positives on commit hashes, consider adding an allowlist entry for this JSON path/pattern:
- packages/komodo_defi_framework/app_build/build_config.json (line 3):
api_commit_hash
15-16: Checksums validated locally; ready for CI integrationAll configured SHA-256 values in
packages/komodo_defi_framework/app_build/build_config.jsonare 64-character lowercase hex and unique across platforms. Next step: integrate a CI job that, on every PR, downloads each platform artifact and recomputes its SHA-256 to gate merges.• No invalid or duplicate checksums detected in lines 15–16, 22–23, 29–30, 36–37, 43–44, 50–51, or 57–58
• Recommend adding a CI pipeline stage using the above script (or equivalent) against published artifacts
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/komodo_defi_framework/app_build/build_config.json(3 hunks)
🧰 Additional context used
🪛 Gitleaks (8.27.2)
packages/komodo_defi_framework/app_build/build_config.json
3-3: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build_and_preview_sdk_example_preview
- GitHub Check: build_and_preview_playground_preview
- GitHub Check: Flutter tests (all packages)
🔇 Additional comments (2)
packages/komodo_defi_framework/app_build/build_config.json (2)
1-85: LGTM overallValue-only bumps to SHAs and checksums. No structural changes. Ship it after the quick verifications pass.
66-66: Verified: Bundled coins repo commit exists on master
- Confirmed that commit
89730c278a89253e99352b5dfef9226e3043699cexists in KomodoPlatform/coins.- Confirmed that this commit is on the
masterbranch lineage.No further action required.
Summary by CodeRabbit