Skip to content

build(kdf): bump KDF commit hash and checksums#210

Closed
takenagain wants to merge 1 commit intodevfrom
build/update-kdf-hash
Closed

build(kdf): bump KDF commit hash and checksums#210
takenagain wants to merge 1 commit intodevfrom
build/update-kdf-hash

Conversation

@takenagain
Copy link
Copy Markdown
Contributor

@takenagain takenagain commented Aug 27, 2025

Summary by CodeRabbit

  • Chores
    • Synchronized build references to the latest backend commit and refreshed platform package checksums across Web, iOS, macOS, Windows, Android (armv7, aarch64), and Linux.
    • Ensures consistent, verified binaries across all distributions for improved integrity and reliability.
    • No functional, UI, or behavioral changes are introduced in this update; end users should experience the same features and workflows as before.

@takenagain takenagain self-assigned this Aug 27, 2025
Copilot AI review requested due to automatic review settings August 27, 2025 15:18
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 27, 2025

Walkthrough

Updated build_config.json to point to a new api_commit_hash and bundles_coins_repo_commit, and refreshed valid_zip_sha256_checksums for all listed platforms. No structural changes; only value updates to existing keys.

Changes

Cohort / File(s) Summary
Build config hash updates
packages/komodo_defi_framework/app_build/build_config.json
Updated api_commit_hash, bundles_coins_repo_commit, and platforms.*.valid_zip_sha256_checksums for web, ios, macos, windows, android-armv7, android-aarch64, and linux. No schema or path changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • CharlVS

Poem

A nibble of hashes, a hop through the night,
I tweak the checksums till everything’s right.
New commits sparkle like stars in a row,
Bundles updated—off we go!
Thump-thump, ears up—release in sight. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch build/update-kdf-hash

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the KDF (Komodo DeFi Framework) build configuration to use a newer commit hash and corresponding SHA256 checksums. The update affects both the API commit reference and the bundled coins repository commit.

  • Updates API commit hash to a newer version
  • Updates SHA256 checksums for all platform-specific binary packages to match the new build
  • Updates bundled coins repository commit hash

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@takenagain
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 27, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
packages/komodo_defi_framework/app_build/build_config.json (2)

3-3: Confirmed commit SHA and suggested Gitleaks allowlist

Verified that commit 80766b0056062797c3c385b9d1497bb31ac00139 exists in KomodoPlatform/komodo-defi-framework and is reachable from the dev branch. The change to the api_commit_hash field is valid.

To prevent future Gitleaks false positives on commit hashes, consider adding an allowlist entry for this JSON path/pattern:

  • packages/komodo_defi_framework/app_build/build_config.json (line 3): api_commit_hash

15-16: Checksums validated locally; ready for CI integration

All configured SHA-256 values in packages/komodo_defi_framework/app_build/build_config.json are 64-character lowercase hex and unique across platforms. Next step: integrate a CI job that, on every PR, downloads each platform artifact and recomputes its SHA-256 to gate merges.

• No invalid or duplicate checksums detected in lines 15–16, 22–23, 29–30, 36–37, 43–44, 50–51, or 57–58
• Recommend adding a CI pipeline stage using the above script (or equivalent) against published artifacts

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 27acd7f and baae26b.

📒 Files selected for processing (1)
  • packages/komodo_defi_framework/app_build/build_config.json (3 hunks)
🧰 Additional context used
🪛 Gitleaks (8.27.2)
packages/komodo_defi_framework/app_build/build_config.json

3-3: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build_and_preview_sdk_example_preview
  • GitHub Check: build_and_preview_playground_preview
  • GitHub Check: Flutter tests (all packages)
🔇 Additional comments (2)
packages/komodo_defi_framework/app_build/build_config.json (2)

1-85: LGTM overall

Value-only bumps to SHAs and checksums. No structural changes. Ship it after the quick verifications pass.


66-66: Verified: Bundled coins repo commit exists on master

  • Confirmed that commit 89730c278a89253e99352b5dfef9226e3043699c exists in KomodoPlatform/coins.
  • Confirmed that this commit is on the master branch lineage.

No further action required.

@takenagain takenagain closed this Aug 27, 2025
@takenagain takenagain deleted the build/update-kdf-hash branch August 27, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants