Skip to content

KDF: Nebula branch-based mirror + href resolution; macOS universal support; update staging checksums#237

Merged
CharlVS merged 11 commits intodevfrom
add/macos-universal-support
Oct 9, 2025
Merged

KDF: Nebula branch-based mirror + href resolution; macOS universal support; update staging checksums#237
CharlVS merged 11 commits intodevfrom
add/macos-universal-support

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Oct 9, 2025

This PR refactors and enhances the API updater and KDF fetcher to accommodate branch-based Nebula mirror listings (similar to devbuilds), robustly resolve download links via the full href, and ensure macOS universal builds are preferred when available.

Key changes

  • update_api_config.dart: resolve mirror links using full href; search both branch-scoped and base listings; pattern checks on Uri.path to ignore query strings.
  • DevBuildsArtefactDownloader: resolve via href; support both branch and base listings; ignore wallet artifacts; pattern checks on Uri.path; minimal scope.
  • macOS: matching_preference updated to prefer universal2 artifacts; verified Nebula provides kdf-macos-universal2-.zip.
  • build_config.json: update to latest staging commit and append new checksums from Nebula across platforms.
  • Docs: clarify Nebula usage, branch-scoped listings, short-hash allowance, and universal2 preference.

Notes

  • No breaking refactors; changes are localized.
  • Additional logging for traceability.

Testing

  • Ran updater against Nebula staging; verified artifacts found across all platforms and checksums appended, including kdf-macos-universal2-.zip selection.

Note

Adds Nebula branch/base mirror support with short-hash href resolution, prefers macOS universal2, updates staging commit/checksums, and enhances CLI/downloader logic (incl. strict mode).

  • Build/Downloaders:
    • Support Nebula mirror with branch-scoped and base listings; resolve absolute/relative href and ignore wallet archives.
    • Match by full or 7-char short commit; add preference-based selection via matching_preference.
    • Improve logs and unzip calls; stricter "not found" errors.
  • CLI (update_api_config.dart):
    • Default branch main; add --commit (short/full), --strict flag, and short-to-full SHA resolution.
    • Prefer assets using matching_preference; accumulate unique checksums instead of replacing.
  • Config (app_build/build_config.json):
    • Update api_commit_hash to 8beb119..., branch to staging; add Nebula source URL.
    • Add macOS matching_preference (prefer universal2) and extend platform checksum lists.
  • macOS Podspec:
    • Release-only fat-binary thinning, re-sign modified binaries; allow universal (arm64+x86_64) builds; keep rpaths.
  • Docs:
    • README: Nebula usage, branch listings, short-hash pinning, and macOS universal2 naming/pattern.
  • Misc:
    • Example/playground macOS deployment target to 10.15; update pod lockfiles; add workspace settings.

Written by Cursor Bugbot for commit bd2dfb9. This will update automatically on new commits. Configure here.

smk762 and others added 8 commits October 7, 2025 09:24
…dk-flutter into universal-mac-builds

# Conflicts:
#	packages/komodo_defi_framework/app_build/build_config.json
…rtifacts; --[no-]strict flag; update usage examples
- update_api_config.dart: resolve mirror links using full href; inspect branch and base listings; normalize href path for pattern checks
- dev_builds_artefact_downloader: resolve links via href; search branch/base listings; ignore wallet artifacts; use Uri.path for matching
- build_config.json: update staging branch checksums after Nebula fetch
- docs: clarify Nebula usage and branch-based listings

Also includes minor logging improvements and no breaking refactors.
Copilot AI review requested due to automatic review settings October 9, 2025 15:03
@CharlVS CharlVS changed the title KDF: support branch-based Nebula mirror + href resolution; update staging checksums KDF: Nebula branch-based mirror + href resolution; macOS universal support; update staging checksums Oct 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the API updater and KDF fetcher to support branch-based Nebula mirror listings, improves download link resolution using full href paths, and adds preference support for macOS universal builds.

  • Enhanced DevBuildsArtefactDownloader to support both branch-scoped and base directory listings for better mirror compatibility
  • Added matching preference system to prioritize universal2 artifacts over platform-specific ones for macOS
  • Updated build configuration to use latest staging commit with new checksums across all platforms

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
api_file_matching_config.dart Adds matching preference system with choosePreferred method
api_build_platform_config.dart Integrates matching preference support into platform configuration
fetch_defi_api_build_step.dart Minor formatting improvements and checksum overlap logic update
github_artefact_downloader.dart Implements preference-based selection for GitHub artifacts
dev_builds_artefact_downloader.dart Major refactor to support multiple listing URLs and href resolution
komodo_defi_framework.podspec* Removes x86_64 exclusion to enable universal macOS builds
build_config.json Updates to latest staging commit with new checksums and macOS universal2 preference
BUILD_CONFIG_README.md Adds documentation for Nebula mirror usage and short hash support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread packages/komodo_wallet_cli/bin/update_api_config.dart Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

Visit the preview URL for this PR (updated for commit bd2dfb9):

https://komodo-playground--pr237-add-macos-universal-b733t3ug.web.app

(expires Thu, 16 Oct 2025 16:42:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

Visit the preview URL for this PR (updated for commit bd2dfb9):

https://kdf-sdk--pr237-add-macos-universal-0gdmcib2.web.app

(expires Thu, 16 Oct 2025 16:42:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add/macos-universal-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

cursor[bot]

This comment was marked as outdated.

@CharlVS CharlVS merged commit 5e6a106 into dev Oct 9, 2025
8 of 9 checks passed
@CharlVS CharlVS deleted the add/macos-universal-support branch October 9, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants