Conversation
…dk-flutter into universal-mac-builds # Conflicts: # packages/komodo_defi_framework/app_build/build_config.json
Co-authored-by: charl <charl@vanstaden.info>
…rtifacts; --[no-]strict flag; update usage examples
- update_api_config.dart: resolve mirror links using full href; inspect branch and base listings; normalize href path for pattern checks - dev_builds_artefact_downloader: resolve links via href; search branch/base listings; ignore wallet artifacts; use Uri.path for matching - build_config.json: update staging branch checksums after Nebula fetch - docs: clarify Nebula usage and branch-based listings Also includes minor logging improvements and no breaking refactors.
…se builds; re-sign artifacts
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the API updater and KDF fetcher to support branch-based Nebula mirror listings, improves download link resolution using full href paths, and adds preference support for macOS universal builds.
- Enhanced DevBuildsArtefactDownloader to support both branch-scoped and base directory listings for better mirror compatibility
- Added matching preference system to prioritize universal2 artifacts over platform-specific ones for macOS
- Updated build configuration to use latest staging commit with new checksums across all platforms
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| api_file_matching_config.dart | Adds matching preference system with choosePreferred method |
| api_build_platform_config.dart | Integrates matching preference support into platform configuration |
| fetch_defi_api_build_step.dart | Minor formatting improvements and checksum overlap logic update |
| github_artefact_downloader.dart | Implements preference-based selection for GitHub artifacts |
| dev_builds_artefact_downloader.dart | Major refactor to support multiple listing URLs and href resolution |
| komodo_defi_framework.podspec* | Removes x86_64 exclusion to enable universal macOS builds |
| build_config.json | Updates to latest staging commit with new checksums and macOS universal2 preference |
| BUILD_CONFIG_README.md | Adds documentation for Nebula mirror usage and short hash support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
|
Visit the preview URL for this PR (updated for commit bd2dfb9): https://komodo-playground--pr237-add-macos-universal-b733t3ug.web.app (expires Thu, 16 Oct 2025 16:42:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
|
Visit the preview URL for this PR (updated for commit bd2dfb9): https://kdf-sdk--pr237-add-macos-universal-0gdmcib2.web.app (expires Thu, 16 Oct 2025 16:42:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR refactors and enhances the API updater and KDF fetcher to accommodate branch-based Nebula mirror listings (similar to devbuilds), robustly resolve download links via the full href, and ensure macOS universal builds are preferred when available.
Key changes
Notes
Testing
Note
Adds Nebula branch/base mirror support with short-hash href resolution, prefers macOS universal2, updates staging commit/checksums, and enhances CLI/downloader logic (incl. strict mode).
hrefand ignore wallet archives.matching_preference.update_api_config.dart):main; add--commit(short/full),--strictflag, and short-to-full SHA resolution.matching_preference; accumulate unique checksums instead of replacing.app_build/build_config.json):api_commit_hashto8beb119..., branch tostaging; add Nebula source URL.matching_preference(preferuniversal2) and extend platform checksum lists.universal2naming/pattern.Written by Cursor Bugbot for commit bd2dfb9. This will update automatically on new commits. Configure here.