feat(types): parent display name suffix via subclass#213
Conversation
- Add CoinSubClass.tokenStandardSuffix (exhaustive switch) - Add AssetId.displayName (parent-only) using tokenStandardSuffix - No suffix for child assets; no changes to ids or balances Refs: GLEECBTC/gleec-wallet#2988 (comment)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements parent-chain disambiguation in the SDK by adding token standard suffixes to parent asset display names. The feature helps differentiate between assets with the same name but on different networks.
- Adds a
tokenStandardSuffixextension toCoinSubClasswith exhaustive switch coverage - Introduces
AssetId.displayNameproperty that appends suffixes for parent assets only - Provides standardized network abbreviations (ERC20, BEP20, ARB20, etc.) for display disambiguation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| coin_subclasses.dart | Adds extension with token standard suffix mapping for all coin subclasses |
| asset_id.dart | Implements displayName getter that conditionally appends network suffixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Implements parent-chain disambiguation in SDK.
Context: GLEECBTC/gleec-wallet#2988 (comment)