Conversation
This reverts commit 6804869.
This reverts commit 4a5f2aa.
… errors; ignore all sia_docker_tests
removes rpc_started from MmCtx for wasm target
…multithreaded instances of KDF within a single process" This reverts commit 8f60562.
…rate allowing newer versions with breaking changes - bump to 1.5.3
add SiaTestnetContainer type add CHARLIE_SIA_KEYPAIR static
add stub for shared container test
incorporates V2TransactionBuilder add_siacoin_input_with_basis and update_basis methods
…located so tests can run concurrently
shamardy
commented
Nov 14, 2025
shamardy
force-pushed
the
sia-rc-cleanup
branch
from
07b5b03 to
61faef3
Compare
shamardy
commented
Nov 14, 2025
shamardy
commented
Nov 18, 2025
|
|
||
| // Convert the DexFee to a Currency amount | ||
| let trade_fee_amount = match dex_fee { | ||
| DexFee::Standard(mm_num) => siacoin_to_hastings(BigDecimal::from(mm_num))?, |
Collaborator
Author
There was a problem hiding this comment.
Fee burn is not implemented which is fine for this PR but leaving this comment for reference
Collaborator
Author
|
@mariocynicys this commit d9940e2 makes total amount and spent by me similar to EVM and Solana (in the Solana PR) implementation. UTXO, tendermint and others might need similar fixes but I didn't do it in this PR. Please give it a second look in case I made mistakes. |
…note inside the function says
set the internal id correctly in transaction details for sia history fetching loop this should fix what GLEECBTC/gleec-wallet#3405 is trying to fix but from KDF side.
smk762
approved these changes
Nov 24, 2025
smk762
left a comment
smk762
left a comment
There was a problem hiding this comment.
All reported bugs addressed, and core functionality confirmed in Komodo Wallet GUI for all OS.
- bestorders response ✔️
- transaction history ✔️
- maker tx parsing ✔️
Thanks all for the hard work!
This was referenced Nov 25, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.