refactor(toolchain): general stabilization for stable rust by onur-ozkan · Pull Request #2528 · GLEECBTC/komodo-defi-framework

onur-ozkan · 2025-07-08T14:23:28Z

Migrated to the stable compiler 1.85.1. Several crates (including mm2_db, common and mm2_p2p) have been stabilized and various dependencies are updated with removing their nightly feature. However some crates (like as mm2_state_machine, mm2_err_handle and certain test crates) still retain nightly features due to their practical benefits in those contexts.

To manage this, added a list of crates allowed to use nightly features in .cargo/config. This allows us to continue using a stable compiler while selectively enabling nightly for specific crates when necessary. As features become stabilized, we can remove those crates from the list.

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan · 2025-07-17T08:28:28Z

mm2src/mm2_state_machine/src/lib.rs

-// Makes the error conversion work for structs/enums containing Box<dyn ...>
-impl<T: ?Sized, A: Allocator> NotSame for Box<T, A> {}


This was an unnecessary nightly dependency as we don't use it anywhere.

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan · 2025-07-21T06:44:02Z

I will fix fmt and clippy errors after the PR is approved to avoid generating a large diff which can make this PR to harder to review.

shamardy

Only one small fix is needed! I will check the CI after you fix fmt and clippy but let's wait for another approval first.

.cargo/config.toml

mm2src/mm2_p2p/src/behaviours/peers_exchange.rs

Signed-off-by: Onur Özkan <work@onurozkan.dev>

dimxy

LGTM

… into stable-compiler

Signed-off-by: Onur Özkan <work@onurozkan.dev>

mariocynicys

nit & other nits

mm2src/common/common.rs

mm2src/mm2_net/src/ip_addr.rs

Signed-off-by: Onur Özkan <work@onurozkan.dev>

* dev: fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) # Conflicts: # mm2src/mm2_main/tests/integration_tests_common/mod.rs

* dev: (21 commits) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) fix(ci): adds nodejs 20 to ci-container (#2536) fix(WASM and Debian): fix build failures (#2534) improvement(event-streaming): impl DeriveStreamerId trait for all streamers (#2489) fix(eth): Propagate structured EIP-1559 fee errors (#2532) fix(eth): Correctly implement ETH max withdrawal logic (#2531) feat(use-clap-for-cli): use clap to parse CLI-Args #2215 (#2510) feat(orderbook): expirable maker orders (#2516) improvement(eth): drop parity support (#2527) chore(release): finalize changelog for v2.5.0-beta (#2524) chore(toolchain): upgrade toolchain to nightly 1.86.0 (#2444) ... # Conflicts: # mm2src/coins/lp_coins.rs # mm2src/coins/rpc_command/get_new_address.rs # mm2src/trezor/src/eth/eth_command.rs

* dev: feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) fix(ci): adds nodejs 20 to ci-container (#2536) fix(WASM and Debian): fix build failures (#2534) improvement(event-streaming): impl DeriveStreamerId trait for all streamers (#2489) chore(release): v2.3.0-beta (#2284) # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_tests.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/nft.rs # mm2src/coins/qrc20.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

* dev: (24 commits) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580) fix(clippy): fix clippy warnings for #2565 (#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (#2563) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) ... # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_tests.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/nft.rs # mm2src/coins/qrc20.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

This commit migrates to the stable compiler 1.85.1, some crates (like as mm2_state_machine, mm2_err_handle and certain test crates) still retain nightly features due to their practical benefits in those contexts.

onur-ozkan added 11 commits July 7, 2025 14:42

switch to stable 1.85.1

8b4f417

Signed-off-by: Onur Özkan <work@onurozkan.dev>

remove nightly compiler build flag

f999117

Signed-off-by: Onur Özkan <work@onurozkan.dev>

create NotStandardStateMachine and NotInitialState markers

f9b23c9

Signed-off-by: Onur Özkan <work@onurozkan.dev>

remove redundant trait implementation

66ec22a

Signed-off-by: Onur Özkan <work@onurozkan.dev>

remove auto trait in state_machine

8245767

Signed-off-by: Onur Özkan <work@onurozkan.dev>

enable rustc_bootstrap

d2b0a15

Signed-off-by: Onur Özkan <work@onurozkan.dev>

make mm2_p2p nightly free

01c0ead

Signed-off-by: Onur Özkan <work@onurozkan.dev>

make mm2_test_helpers nightly free

ea23558

Signed-off-by: Onur Özkan <work@onurozkan.dev>

drop outdated #![feature(stmt_expr_attributes)]

9c3a5d5

Signed-off-by: Onur Özkan <work@onurozkan.dev>

drop #![feature(hash_raw_entry)] features

f9199c6

Signed-off-by: Onur Özkan <work@onurozkan.dev>

stabilize mm2_db

b0f8e93

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan added the status: in progress label Jul 8, 2025

allow nightly features only on specific crates

43a0704

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan force-pushed the stable-compiler branch from 8d55663 to 43a0704 Compare July 17, 2025 07:56

onur-ozkan added 4 commits July 17, 2025 11:05

use stable parking lot

172d89f

Signed-off-by: Onur Özkan <work@onurozkan.dev>

stabilize gstuff

4449b00

Signed-off-by: Onur Özkan <work@onurozkan.dev>

fix typo

6c193bf

Signed-off-by: Onur Özkan <work@onurozkan.dev>

document RUSTC_BOOTSTRAP

71c2566

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan commented Jul 17, 2025

View reviewed changes

onur-ozkan added 4 commits July 17, 2025 11:30

re-utilize negative traits

a3258e5

Signed-off-by: Onur Özkan <work@onurozkan.dev>

remove experimental rustfmt feature

7c89569

Signed-off-by: Onur Özkan <work@onurozkan.dev>

handle test crates

305462c

Signed-off-by: Onur Özkan <work@onurozkan.dev>

update CI pipelines to install stable compiler

9adac55

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan added improvement: security Improvements made on runtime security status: pending review improvement: build time improvement: binary optimizations and removed status: in progress labels Jul 21, 2025

onur-ozkan marked this pull request as ready for review July 21, 2025 06:42

onur-ozkan requested a review from shamardy July 21, 2025 06:49

shamardy reviewed Jul 21, 2025

View reviewed changes

.cargo/config.toml Show resolved Hide resolved

mm2src/mm2_p2p/src/behaviours/peers_exchange.rs Outdated Show resolved Hide resolved

nit

e4a08e0

Signed-off-by: Onur Özkan <work@onurozkan.dev>

dimxy previously approved these changes Jul 22, 2025

View reviewed changes

onur-ozkan added 3 commits July 22, 2025 15:12

Merge branch 'dev' of github.com:KomodoPlatform/komodo-defi-framework…

6dae698

… into stable-compiler

remove unstable fmt rules

3875a5b

Signed-off-by: Onur Özkan <work@onurozkan.dev>

bless fmt

5aea2c5

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan dismissed dimxy’s stale review via 5aea2c5 July 22, 2025 12:16

mariocynicys previously approved these changes Jul 22, 2025

View reviewed changes

mm2src/common/common.rs Show resolved Hide resolved

mm2src/common/common.rs Show resolved Hide resolved

mm2src/mm2_net/src/ip_addr.rs Show resolved Hide resolved

mm2src/mm2_net/src/ip_addr.rs Show resolved Hide resolved

explain why NotSend is not Send

48bc234

Signed-off-by: Onur Özkan <work@onurozkan.dev>

onur-ozkan dismissed mariocynicys’s stale review via 48bc234 July 23, 2025 05:01

shamardy approved these changes Jul 24, 2025

View reviewed changes

shamardy added the 2.6.0-beta label Jul 24, 2025

shamardy merged commit daf43eb into dev Jul 24, 2025
18 of 33 checks passed

shamardy deleted the stable-compiler branch July 24, 2025 17:49

shamardy mentioned this pull request Jul 24, 2025

Update of rust-toolchain version #1972

Closed

shamardy mentioned this pull request Nov 25, 2025

chore(release): v2.6.0-beta #2696

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(toolchain): general stabilization for stable rust#2528

refactor(toolchain): general stabilization for stable rust#2528
shamardy merged 25 commits intodevfrom
stable-compiler

onur-ozkan commented Jul 8, 2025 •

edited

Loading

Uh oh!

onur-ozkan Jul 17, 2025

Uh oh!

onur-ozkan commented Jul 21, 2025 •

edited

Loading

Uh oh!

shamardy left a comment

Uh oh!

Uh oh!

Uh oh!

dimxy left a comment

Uh oh!

mariocynicys left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		// Makes the error conversion work for structs/enums containing Box<dyn ...>
		impl<T: ?Sized, A: Allocator> NotSame for Box<T, A> {}

Conversation

onur-ozkan commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onur-ozkan Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

onur-ozkan commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shamardy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dimxy left a comment

Choose a reason for hiding this comment

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

onur-ozkan commented Jul 8, 2025 •

edited

Loading

onur-ozkan commented Jul 21, 2025 •

edited

Loading