feat(spark): support FIRO Spark verbose tx#2396
Conversation
|
first PR was closed due to some issues, this new one has been opened as a replacement |
shamardy
left a comment
There was a problem hiding this comment.
Thanks for re-opening the PR based on dev. Next review iteration!
5add25e to
d7dc8c7
Compare
|
@levoncrypto There are still problems in serializations and deserializations which is why I assume in |
Change v_extra_payload as Option and deserialize call case for spark
d7dc8c7 to
4037143
Compare
c040e49 to
39e7c96
Compare
shamardy
left a comment
There was a problem hiding this comment.
Thank you for the fixes! A few more notes :)
Q: Do we need to set this extra payload for transactions generated by KDF or is it not needed for standard transactions.
|
Extra payload need only for special transactions. |
shamardy
left a comment
There was a problem hiding this comment.
Amazing Work! Will wait for CI to finish before merging!
This update introduces support for Spark verbose. The new integration ensures that the framework now supports Spark transaction parsing, expanding its capabilities for handling privacy-focused transactions.
The implementation maintains the core functionality while enhancing the framework’s versatility. I believe this addition will benefit users by providing a broader range of supported transactions within the Komodo Defi framework.