feat(spark): support FIRO Spark verbose tx#2394
Closed
levoncrypto wants to merge 12 commits intoGLEECBTC:devfrom
Closed
feat(spark): support FIRO Spark verbose tx#2394levoncrypto wants to merge 12 commits intoGLEECBTC:devfrom
levoncrypto wants to merge 12 commits intoGLEECBTC:devfrom
Conversation
[release] v1.0.3
[release] v1.0.4-beta
chore(release): v1.0.5-beta
chore(release): v1.0.6-beta
chore(release): v1.0.7-beta
chore(release): v2.0.0-beta
chore(release): v2.1.0-beta
chore(release): v2.2.0-beta
* feat(LRAPI): add 1inch classic swap rpc (GLEECBTC#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (GLEECBTC#2285) * improvement(error-handling): main files (GLEECBTC#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (GLEECBTC#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (GLEECBTC#2289) Signed-off-by: onur-ozkan <work@onurozkan.dev> * chore(ctx): replace gstuff constructible with oncelock (GLEECBTC#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (GLEECBTC#2290) * bump libp2p (GLEECBTC#2296) Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: dimxy <dimxy@komodoplatform.com> Co-authored-by: Onur Özkan <work@onurozkan.dev> Co-authored-by: Samuel Onoja <samiodev@icloud.com> Co-authored-by: DeckerSU <support@decker.su>
Merge commit 'fe5a274f9e7581644c0d9e2e3112ad64ebc6c056' into main
chore(git-history): resolve history diversion between main & dev
levoncrypto
changed the title
levoncrypto
changed the title
shamardy
changed the title
Collaborator
|
@levoncrypto please change the base branch to dev |
Collaborator
|
@levoncrypto you will need to rebase to dev as well :) |
shamardy
reviewed
Mar 19, 2025
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Thanks for the PR! It would be helpful if you added test coverage for Spark txs similar to the below
https://github.com/levoncrypto/komodo-defi-framework/blob/6db5b9fb2debdaac401007bcffd71512474382a3/mm2src/mm2_bitcoin/chain/src/transaction.rs#L975-L982
https://github.com/levoncrypto/komodo-defi-framework/blob/f401497aee55ee8152f96955bd40dd147b8ab88f/mm2src/coins/utxo/utxo_tests.rs#L2794-L2837
| pub script_sig: TransactionInputScript, | ||
| #[serde(rename = "nFees")] | ||
| pub n_fees: f64, | ||
| lTags: Vec<String>, |
Collaborator
There was a problem hiding this comment.
Suggested change
| lTags: Vec<String>, | |
| #[serde(rename = "lTags")] | |
| l_tags: Vec<String>, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces support for Spark verbose. The new integration ensures that the framework now supports Spark transaction parsing, expanding its capabilities for handling privacy-focused transactions.
The implementation maintains the core functionality while enhancing the framework’s versatility. I believe this addition will benefit users by providing a broader range of supported transactions within the Komodo Defi framework.