feat(rpc): add is_success field to legacy MySwapStatusResponse#2371
Merged
feat(rpc): add is_success field to legacy MySwapStatusResponse#2371
Conversation
shamardy
reviewed
Feb 24, 2025
shamardy
force-pushed
the
feat/swapstatus-is-success
branch
from
340bce8 to
70a2ab7
Compare
Collaborator
|
This PR also allows branch names such as |
Collaborator
|
@onur-ozkan I can separate the CI changes into a different PR if you think it's better. |
onur-ozkan
reviewed
Mar 3, 2025
It's fairly simple so no needed. |
onur-ozkan
approved these changes
Mar 3, 2025
onur-ozkan
left a comment
onur-ozkan
left a comment
There was a problem hiding this comment.
LGTM with/without #2371 (comment)
dimxy
pushed a commit
that referenced
this pull request
Mar 5, 2025
* dev: feat(rpc): add is_success field to legacy MySwapStatusResponse (#2371) fix(key-derivation): use stored Argon2 parameters instead of default values (#2360) fix(tests): stabilize `tendermint_coin::test_claim_staking_rewards` (#2373) improvement(RPCs): group staking rpcs under a namespace (#2372) feat(tendermint): claim delegation rewards (#2351) fix(eth-tpu): remove state from funding validation (#2334) improvement(rpc-server): rpc server dynamic port allocation (#2342) fix(tests): fix or ignore unstable tests (#2365) fix(fs): make `filter_files_by_extension` return only files (#2364) fix(derive_key_from_path): check length of current_key_material (#2356) chore(release): bump mm2 version to 2.4.0-beta (#2346) fix(tests): add additional testnet sepolia nodes to test code (#2358) fix(swaps): maintain legacy compatibility for negotiation messages (#2353) refactor(SwapOps): impl defaults for protocol specific swapops fns (#2354) feat(tpu-v2): provide swap protocol versioning (#2324) feat(wallet): add change mnemonic password rpc (#2317)
dimxy
pushed a commit
that referenced
this pull request
Mar 21, 2025
* dev: fix(tx-history): fix unhandled IBC and HTLC events (#2385) improvement(dep-stack): replace deprecated `instant` dependency (#2391) feat(tendermint): staking queries (#2377) refactor(eth): use trait addr_to_string method instead of old function (#2348) fix(ci): use correct rustup component syntax in fmt-and-lint job (#2390) refactor(tx-query): use TxSearchRequest for tx queries (#2384) refactor(tpu-v2): allow to skip p2p message with taker payment spend preimage for eth (#2359) feat(rpc): add is_success field to legacy MySwapStatusResponse (#2371) fix(key-derivation): use stored Argon2 parameters instead of default values (#2360) fix(tests): stabilize `tendermint_coin::test_claim_staking_rewards` (#2373) improvement(RPCs): group staking rpcs under a namespace (#2372)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an additional field for the
my_swap_statusRPC response for v1/legacy swaps. This field is only included if the swap is finished and is successful.