fix(tx-history): fix unhandled IBC and HTLC events#2385
Merged
Conversation
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
changed the title
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
unhandled-tx-error-coverage
branch
from
808e89b to
ffc0a02
Compare
borngraced
reviewed
Mar 11, 2025
| if i >= tx_events.len() { | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
this condition can never be true...or is my assumption wrong? cc. @onur-ozkan
Author
There was a problem hiding this comment.
It can be true when tx_events.remove is called. I will add explanatory comment on this.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Author
|
cc @KomodoPlatform/qa for testing. |
smk762
approved these changes
Mar 19, 2025
smk762
left a comment
smk762
left a comment
There was a problem hiding this comment.
Confirming log error no longer seen. Related transaction appears in IRIS history (but not ATOM-IRIS_IBC). This may be a limitation of tendermint rpc responses? Will open separate issue for this.
shamardy
approved these changes
Mar 20, 2025
dimxy
pushed a commit
that referenced
this pull request
Mar 21, 2025
* dev: fix(tx-history): fix unhandled IBC and HTLC events (#2385) improvement(dep-stack): replace deprecated `instant` dependency (#2391) feat(tendermint): staking queries (#2377) refactor(eth): use trait addr_to_string method instead of old function (#2348) fix(ci): use correct rustup component syntax in fmt-and-lint job (#2390) refactor(tx-query): use TxSearchRequest for tx queries (#2384) refactor(tpu-v2): allow to skip p2p message with taker payment spend preimage for eth (#2359) feat(rpc): add is_success field to legacy MySwapStatusResponse (#2371) fix(key-derivation): use stored Argon2 parameters instead of default values (#2360) fix(tests): stabilize `tendermint_coin::test_claim_staking_rewards` (#2373) improvement(RPCs): group staking rpcs under a namespace (#2372)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2347