refactor(tpu-v2): allow to skip p2p message with taker payment spend preimage for eth#2359
Merged
refactor(tpu-v2): allow to skip p2p message with taker payment spend preimage for eth#2359
Conversation
laruh
force-pushed
the
skip-preimage-p2p-msg-in-tpu
branch
from
097f6f8 to
1240973
Compare
laruh
force-pushed
the
skip-preimage-p2p-msg-in-tpu
branch
from
1240973 to
92d7c7f
Compare
onur-ozkan
reviewed
Feb 17, 2025
onur-ozkan
reviewed
Feb 19, 2025
onur-ozkan
reviewed
Feb 19, 2025
shamardy
previously approved these changes
Mar 5, 2025
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
LGTM! Only one nit. I overlooked the code duplication as it will be handled in the refactor discussed on DM. You can leave info about the discussed refactor in this PR or the related issue for reference.
…ingSkipped swap event in recreate machine
Author
I created the issue with information #2380 and added its link to this PR description |
shamardy
approved these changes
Mar 6, 2025
dimxy
pushed a commit
that referenced
this pull request
Mar 17, 2025
* dev: refactor(eth): use trait addr_to_string method instead of old function (#2348) fix(ci): use correct rustup component syntax in fmt-and-lint job (#2390) refactor(tx-query): use TxSearchRequest for tx queries (#2384) refactor(tpu-v2): allow to skip p2p message with taker payment spend preimage for eth (#2359)
dimxy
pushed a commit
that referenced
this pull request
Mar 21, 2025
* dev: fix(tx-history): fix unhandled IBC and HTLC events (#2385) improvement(dep-stack): replace deprecated `instant` dependency (#2391) feat(tendermint): staking queries (#2377) refactor(eth): use trait addr_to_string method instead of old function (#2348) fix(ci): use correct rustup component syntax in fmt-and-lint job (#2390) refactor(tx-query): use TxSearchRequest for tx queries (#2384) refactor(tpu-v2): allow to skip p2p message with taker payment spend preimage for eth (#2359) feat(rpc): add is_success field to legacy MySwapStatusResponse (#2371) fix(key-derivation): use stored Argon2 parameters instead of default values (#2360) fix(tests): stabilize `tendermint_coin::test_claim_staking_rewards` (#2373) improvement(RPCs): group staking rpcs under a namespace (#2372)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maker log https://gist.github.com/laruh/04246af979fbe9c8f2c4c3911f1a1d5b (sell UTXO, buy EVM)
Taker log https://gist.github.com/laruh/92a1e6e0e14290afe21ffb1b5608bf84 (sell EVM, buy UTXO)
This pr introduces skipping of taker payment spend preimage p2p message broadcast for coins from EVM based chains, as such taker coin actually doesn't need it to process TPU V2.
You can see it in impl
TakerCoinSwapOpsV2forEthCoinhttps://github.com/KomodoPlatform/komodo-defi-framework/blob/84f5c9235f2c90c07c600dd53ca13fd9d63052af/mm2src/coins/eth.rs#L7232-L7251
Note:
Description of a potential improvement #2380