improvement(rpc-server): rpc server dynamic port allocation#2342
Merged
improvement(rpc-server): rpc server dynamic port allocation#2342
Conversation
mariocynicys
changed the title
mariocynicys
added
status: in progress
feature: RPC
improvement: RPC
and removed
feature: RPC
labels
mariocynicys
changed the title
borngraced
suggested changes
Feb 7, 2025
mariocynicys
reviewed
Feb 7, 2025
Author
|
Is there anyway to later retrieve the port number from MmCtx? If not, I will change the |
removes rpc_started from MmCtx for wasm target
|
Will running multiple KDF instances off of the same directory cause issues? If so, will the final revision of this PR protect against running multiple instances off the same directory? Imo, that's bound to happen. |
Collaborator
If these instances are using the same seed/mnemonic then yes it will cause issues. If not, it should not cause issues as I did this before by using a different rpc port when testing swaps locally between 2 nodes and we do this in tests as well. |
shamardy
previously approved these changes
Feb 17, 2025
borngraced
previously approved these changes
Feb 17, 2025
mariocynicys
previously approved these changes
Feb 20, 2025
Collaborator
mariocynicys
left a comment
mariocynicys
left a comment
There was a problem hiding this comment.
a nit. lgtm otherwise.
shamardy
dismissed stale reviews from mariocynicys, borngraced, and themself
via
7bfefe7
shamardy
approved these changes
Feb 20, 2025
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Feb 24, 2025
* dev: (24 commits) fix(eth-tpu): remove state from funding validation (GLEECBTC#2334) improvement(rpc-server): rpc server dynamic port allocation (GLEECBTC#2342) fix(tests): fix or ignore unstable tests (GLEECBTC#2365) fix(fs): make `filter_files_by_extension` return only files (GLEECBTC#2364) fix(derive_key_from_path): check length of current_key_material (GLEECBTC#2356) chore(release): bump mm2 version to 2.4.0-beta (GLEECBTC#2346) fix(tests): add additional testnet sepolia nodes to test code (GLEECBTC#2358) fix(swaps): maintain legacy compatibility for negotiation messages (GLEECBTC#2353) refactor(SwapOps): impl defaults for protocol specific swapops fns (GLEECBTC#2354) feat(tpu-v2): provide swap protocol versioning (GLEECBTC#2324) feat(wallet): add change mnemonic password rpc (GLEECBTC#2317) fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (GLEECBTC#2261) feat(tendermint): unstaking/undelegation (GLEECBTC#2330) fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (GLEECBTC#2333) feat(event-streaming): API-driven subscription management (GLEECBTC#2172) fix(hash-types): remove panic, enforce fixed-size arrays (GLEECBTC#2279) fix(ARRR): store unconfirmed change output (GLEECBTC#2276) feat(tendermint): staking/delegation (GLEECBTC#2322) chore(deps): `timed-map` migration (GLEECBTC#2247) fix(mem-leak): `running_swap` never shrinks (GLEECBTC#2301) ...
dimxy
pushed a commit
that referenced
this pull request
Feb 26, 2025
* dev: feat(tendermint): claim delegation rewards (#2351) fix(eth-tpu): remove state from funding validation (#2334) improvement(rpc-server): rpc server dynamic port allocation (#2342) fix(tests): fix or ignore unstable tests (#2365) fix(fs): make `filter_files_by_extension` return only files (#2364)
dimxy
pushed a commit
that referenced
this pull request
Mar 5, 2025
* dev: feat(rpc): add is_success field to legacy MySwapStatusResponse (#2371) fix(key-derivation): use stored Argon2 parameters instead of default values (#2360) fix(tests): stabilize `tendermint_coin::test_claim_staking_rewards` (#2373) improvement(RPCs): group staking rpcs under a namespace (#2372) feat(tendermint): claim delegation rewards (#2351) fix(eth-tpu): remove state from funding validation (#2334) improvement(rpc-server): rpc server dynamic port allocation (#2342) fix(tests): fix or ignore unstable tests (#2365) fix(fs): make `filter_files_by_extension` return only files (#2364) fix(derive_key_from_path): check length of current_key_material (#2356) chore(release): bump mm2 version to 2.4.0-beta (#2346) fix(tests): add additional testnet sepolia nodes to test code (#2358) fix(swaps): maintain legacy compatibility for negotiation messages (#2353) refactor(SwapOps): impl defaults for protocol specific swapops fns (#2354) feat(tpu-v2): provide swap protocol versioning (#2324) feat(wallet): add change mnemonic password rpc (#2317)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a
rpcportvalue of 0 to be used within the config. This is the standard way of indicating "use any available port". I found this necessary for running many KDF instances in parallel within Sia CI tests.