feat(tendermint): unstaking/undelegation by onur-ozkan · Pull Request #2330 · GLEECBTC/komodo-defi-framework

onur-ozkan · 2025-01-29T07:04:35Z

Adds tendermint protocol support on remove_delegation RPC, and extends tendermint transaction history implementation to support undelegate transactions.

Next is to add staking listing RPCs for delegations, undelegations (with claiming period informations), rewards, etc.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mm2src/mm2_main/tests/docker_tests/tendermint_tests.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

borngraced

Great work! very minor changes.

mm2src/coins/tendermint/tendermint_coin.rs

mm2src/coins/tendermint/tendermint_tx_history_v2.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

borngraced

lgtm 🚀

mm2src/coins/tendermint/tendermint_coin.rs

dimxy · 2025-02-06T15:48:53Z

mm2src/coins/tendermint/tendermint_tx_history_v2.rs

 const IBC_RECEIVE_EVENT: &str = "fungible_token_packet";
 const IBC_NFT_RECEIVE_EVENT: &str = "non_fungible_token_packet";
 const DELEGATE_EVENT: &str = "delegate";
+const UNDELEGATE_EVENT: &str = "unbond";


Isn't this a typo by a chance (not 'unbound')?

No it's not

Signed-off-by: onur-ozkan <work@onurozkan.dev>

dimxy

LGTM

shamardy · 2025-02-07T09:17:39Z

@onur-ozkan please open docs issue for this change.

shamardy

Thanks for the PR. Only one non-blocker comment for the future.

shamardy · 2025-02-07T09:20:27Z

mm2src/coins/lp_coins.rs

+            if req.withdraw_from.is_some() {
+                return MmError::err(DelegationError::InvalidPayload {
+                    reason: "Can't use `withdraw_from` field on 'remove_delegation' RPC for Cosmos.".to_owned(),
+                });
+            }


Non blocker but for docs and maybe future implementations. We should support HD wallet for all delegate/undelegate/etc.. operations. For now such mention in docs that this is done for the enabled address only.

Adds tendermint protocol support on remove_delegation RPC, and extends tendermint transaction history implementation to support undelegate transactions.

onur-ozkan · 2025-02-08T09:06:14Z

@onur-ozkan please open docs issue for this change.

I will once we consider whole staking functionality is implemented. I didn't do this yet as things can change a little bit while implementing remaining parts.

* dev: fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (#2261) feat(tendermint): unstaking/undelegation (#2330) fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (#2333)

* dev: fix(derive_key_from_path): check length of current_key_material (#2356) chore(release): bump mm2 version to 2.4.0-beta (#2346) fix(tests): add additional testnet sepolia nodes to test code (#2358) fix(swaps): maintain legacy compatibility for negotiation messages (#2353) refactor(SwapOps): impl defaults for protocol specific swapops fns (#2354) feat(tpu-v2): provide swap protocol versioning (#2324) feat(wallet): add change mnemonic password rpc (#2317) fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (#2261) feat(tendermint): unstaking/undelegation (#2330) fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (#2333) feat(event-streaming): API-driven subscription management (#2172) fix(hash-types): remove panic, enforce fixed-size arrays (#2279) fix(ARRR): store unconfirmed change output (#2276) feat(tendermint): staking/delegation (#2322) chore(deps): `timed-map` migration (#2247) fix(mem-leak): `running_swap` never shrinks (#2301) chore(dep-bump): libp2p (#2326) refactor(build script): rewrite the main build script (#2319)

* dev: (24 commits) fix(eth-tpu): remove state from funding validation (GLEECBTC#2334) improvement(rpc-server): rpc server dynamic port allocation (GLEECBTC#2342) fix(tests): fix or ignore unstable tests (GLEECBTC#2365) fix(fs): make `filter_files_by_extension` return only files (GLEECBTC#2364) fix(derive_key_from_path): check length of current_key_material (GLEECBTC#2356) chore(release): bump mm2 version to 2.4.0-beta (GLEECBTC#2346) fix(tests): add additional testnet sepolia nodes to test code (GLEECBTC#2358) fix(swaps): maintain legacy compatibility for negotiation messages (GLEECBTC#2353) refactor(SwapOps): impl defaults for protocol specific swapops fns (GLEECBTC#2354) feat(tpu-v2): provide swap protocol versioning (GLEECBTC#2324) feat(wallet): add change mnemonic password rpc (GLEECBTC#2317) fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (GLEECBTC#2261) feat(tendermint): unstaking/undelegation (GLEECBTC#2330) fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (GLEECBTC#2333) feat(event-streaming): API-driven subscription management (GLEECBTC#2172) fix(hash-types): remove panic, enforce fixed-size arrays (GLEECBTC#2279) fix(ARRR): store unconfirmed change output (GLEECBTC#2276) feat(tendermint): staking/delegation (GLEECBTC#2322) chore(deps): `timed-map` migration (GLEECBTC#2247) fix(mem-leak): `running_swap` never shrinks (GLEECBTC#2301) ...

onur-ozkan added 6 commits January 27, 2025 10:57

save initial state

6a52a2d

Signed-off-by: onur-ozkan <work@onurozkan.dev>

save p.o.c state

6061ec5

Signed-off-by: onur-ozkan <work@onurozkan.dev>

wire cosmos undelegate to KDF RPC

d43a500

Signed-off-by: onur-ozkan <work@onurozkan.dev>

stabilize get_delegated_amount

d931c0d

Signed-off-by: onur-ozkan <work@onurozkan.dev>

implement tendermint undelegate tx handling

0fef1c5

Signed-off-by: onur-ozkan <work@onurozkan.dev>

update transaction details for undelegation

46ffac4

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan added status: in progress feature: protocol labels Jan 29, 2025

onur-ozkan added 2 commits January 29, 2025 07:13

add test coverage

2fd997d

Signed-off-by: onur-ozkan <work@onurozkan.dev>

add tx history support for cosmos undelegate txs

7e361b5

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan changed the title ~~feat(cosmos): unstaking~~ feat(tendermint): unstaking/undelegation Jan 30, 2025

onur-ozkan commented Jan 30, 2025

View reviewed changes

mm2src/mm2_main/tests/docker_tests/tendermint_tests.rs Show resolved Hide resolved

onur-ozkan commented Jan 30, 2025

View reviewed changes

mm2src/mm2_main/tests/docker_tests/tendermint_tests.rs Show resolved Hide resolved

onur-ozkan added 2 commits February 2, 2025 07:20

add coverage for DelegationError::TooMuchToUndelegate error

a82d4c2

Signed-off-by: onur-ozkan <work@onurozkan.dev>

lock certain tests

7f5f68a

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the cosmos-unstake branch from 525c015 to 7f5f68a Compare February 2, 2025 08:17

shamardy added the 2.4.0-beta label Feb 3, 2025

shamardy requested review from borngraced and dimxy February 3, 2025 10:32

borngraced suggested changes Feb 3, 2025

View reviewed changes

mm2src/coins/tendermint/tendermint_coin.rs Outdated Show resolved Hide resolved

mm2src/coins/tendermint/tendermint_tx_history_v2.rs Outdated Show resolved Hide resolved

mm2src/coins/tendermint/tendermint_tx_history_v2.rs Outdated Show resolved Hide resolved

apply nits

209c51e

Signed-off-by: onur-ozkan <work@onurozkan.dev>

This comment was marked as off-topic.

Sign in to view

borngraced previously approved these changes Feb 6, 2025

View reviewed changes

dimxy reviewed Feb 6, 2025

View reviewed changes

mm2src/coins/tendermint/tendermint_coin.rs Outdated Show resolved Hide resolved

dimxy reviewed Feb 6, 2025

View reviewed changes

apply nit

c54ba1e

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan dismissed borngraced’s stale review via c54ba1e February 6, 2025 19:12

dimxy approved these changes Feb 7, 2025

View reviewed changes

shamardy removed the status: in progress label Feb 7, 2025

shamardy approved these changes Feb 7, 2025

View reviewed changes

shamardy merged commit 25503b1 into dev Feb 7, 2025

shamardy deleted the cosmos-unstake branch February 7, 2025 09:27

shamardy pushed a commit that referenced this pull request Feb 7, 2025

feat(tendermint): unstaking/undelegation (#2330)

d4537e3

Adds tendermint protocol support on remove_delegation RPC, and extends tendermint transaction history implementation to support undelegate transactions.

shamardy mentioned this pull request Apr 16, 2025

chore(release): v2.4.0-beta #2345

Merged

Conversation

onur-ozkan commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

borngraced left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

borngraced left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dimxy Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

onur-ozkan Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

dimxy left a comment

Choose a reason for hiding this comment

Uh oh!

shamardy commented Feb 7, 2025

Uh oh!

shamardy left a comment

Choose a reason for hiding this comment

Uh oh!

shamardy Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

onur-ozkan commented Feb 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

onur-ozkan commented Jan 29, 2025 •

edited

Loading