Skip to content

feat(tendermint): staking/delegation#2322

Merged
shamardy merged 13 commits intodevfrom
tendermint-delegation
Jan 27, 2025
Merged

feat(tendermint): staking/delegation#2322
shamardy merged 13 commits intodevfrom
tendermint-delegation

Conversation

@onur-ozkan
Copy link
Copy Markdown

@onur-ozkan onur-ozkan commented Jan 15, 2025 •
edited
Loading

Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.

Next is to do the same for undelegation on remove_delegation.

TODO: File a documentation issue on https://github.com/KomodoPlatform/komodo-docs-mdx

@onur-ozkan
P.o.C implementation of cosmos delegation
36c5001 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
improve delegate implementation significantly
037a9dd 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan changed the title feat(tendermint): delegate/undelegate RPCs feat(tendermint): staking/delegation Jan 15, 2025
@onur-ozkan
consolidate QTUM and Cosmos staking
4012550 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the tendermint-delegation branch from 081df90 to 4012550 Compare January 15, 2025 14:46
@onur-ozkan
remove coin field from DelegatePayload
c99ca55 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
minor readibility improvements
d2a6111 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
support delegate transactions in tx_history
15948b0 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
warn on unrecognized events
c42fc6e 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
rename pk to priv_key
6e5e145 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the tendermint-delegation branch 4 times, most recently from 8145b90 to 16dad85 Compare January 16, 2025 10:20
@onur-ozkan
add docker test
1dd2b73 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the tendermint-delegation branch 2 times, most recently from f67185a to 1dd2b73 Compare January 16, 2025 10:47
@onur-ozkan
improve amount calculation slightly
0f08e05 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the tendermint-delegation branch from 4340e37 to 0f08e05 Compare January 20, 2025 10:07
@onur-ozkan onur-ozkan marked this pull request as ready for review January 20, 2025 10:07
laruh
laruh suggested changes Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! code is very clean, I have small notes

@shamardy shamardy self-requested a review January 23, 2025 12:06
shamardy
shamardy previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean and easy to review PR! Only one non-blocker.

@onur-ozkan
create helper closure for balance error
8d44f10 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
laruh
laruh previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

borngraced
borngraced suggested changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work...one not directly related note

dimxy
dimxy reviewed Jan 26, 2025
View reviewed changes
@onur-ozkan
use io::Error
a08dbcb 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
use memo by ref
e3d4c8c 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Copy Markdown
Author

onur-ozkan commented Jan 27, 2025

All notes are resolved.

shamardy
shamardy approved these changes Jan 27, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@shamardy shamardy merged commit 73e0650 into dev Jan 27, 2025
@shamardy shamardy deleted the tendermint-delegation branch January 27, 2025 09:53
shamardy pushed a commit that referenced this pull request Jan 28, 2025
@onur-ozkan @shamardy
feat(tendermint): staking/delegation (#2322)
a5254d6 
Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.
shamardy pushed a commit that referenced this pull request Jan 30, 2025
@onur-ozkan @shamardy
feat(tendermint): staking/delegation (#2322)
b253d19 
Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.
shamardy pushed a commit that referenced this pull request Jan 30, 2025
@onur-ozkan @shamardy
feat(tendermint): staking/delegation (#2322)
59154bd 
Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request Feb 4, 2025
Merge branch 'dev' into burn-dex-fee-for-non-kmd
2645517 
* dev:
  fix(hash-types): remove panic, enforce fixed-size arrays (GLEECBTC#2279)
  fix(ARRR): store unconfirmed change output (GLEECBTC#2276)
  feat(tendermint): staking/delegation (GLEECBTC#2322)
  chore(deps): `timed-map` migration (GLEECBTC#2247)
  fix(mem-leak): `running_swap` never shrinks (GLEECBTC#2301)
  chore(dep-bump): libp2p (GLEECBTC#2326)
  refactor(build script): rewrite the main build script (GLEECBTC#2319)
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request Feb 4, 2025
Merge branch 'dev' into burn-dex-fee-for-non-kmd
114cfe9 
* dev:
  fix(hash-types): remove panic, enforce fixed-size arrays (GLEECBTC#2279)
  fix(ARRR): store unconfirmed change output (GLEECBTC#2276)
  feat(tendermint): staking/delegation (GLEECBTC#2322)
  chore(deps): `timed-map` migration (GLEECBTC#2247)
  fix(mem-leak): `running_swap` never shrinks (GLEECBTC#2301)
  chore(dep-bump): libp2p (GLEECBTC#2326)
  refactor(build script): rewrite the main build script (GLEECBTC#2319)
dimxy pushed a commit that referenced this pull request Feb 16, 2025
Merge branch 'dev' into lr-swap-wip
a52ebc0 
* dev:
  fix(derive_key_from_path): check length of current_key_material (#2356)
  chore(release): bump mm2 version to 2.4.0-beta (#2346)
  fix(tests): add additional testnet sepolia nodes to test code (#2358)
  fix(swaps): maintain legacy compatibility for negotiation messages (#2353)
  refactor(SwapOps): impl defaults for protocol specific swapops fns (#2354)
  feat(tpu-v2): provide swap protocol versioning (#2324)
  feat(wallet): add change mnemonic password rpc (#2317)
  fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (#2261)
  feat(tendermint): unstaking/undelegation (#2330)
  fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (#2333)
  feat(event-streaming): API-driven subscription management (#2172)
  fix(hash-types): remove panic, enforce fixed-size arrays (#2279)
  fix(ARRR): store unconfirmed change output (#2276)
  feat(tendermint): staking/delegation (#2322)
  chore(deps): `timed-map` migration (#2247)
  fix(mem-leak): `running_swap` never shrinks (#2301)
  chore(dep-bump): libp2p (#2326)
  refactor(build script): rewrite the main build script (#2319)
dimxy pushed a commit that referenced this pull request Feb 16, 2025
Merge branch 'dev' into lr-swap-wip
b86f433 
* dev:
  fix(derive_key_from_path): check length of current_key_material (#2356)
  chore(release): bump mm2 version to 2.4.0-beta (#2346)
  fix(tests): add additional testnet sepolia nodes to test code (#2358)
  fix(swaps): maintain legacy compatibility for negotiation messages (#2353)
  refactor(SwapOps): impl defaults for protocol specific swapops fns (#2354)
  feat(tpu-v2): provide swap protocol versioning (#2324)
  feat(wallet): add change mnemonic password rpc (#2317)
  fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (#2261)
  feat(tendermint): unstaking/undelegation (#2330)
  fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (#2333)
  feat(event-streaming): API-driven subscription management (#2172)
  fix(hash-types): remove panic, enforce fixed-size arrays (#2279)
  fix(ARRR): store unconfirmed change output (#2276)
  feat(tendermint): staking/delegation (#2322)
  chore(deps): `timed-map` migration (#2247)
  fix(mem-leak): `running_swap` never shrinks (#2301)
  chore(dep-bump): libp2p (#2326)
  refactor(build script): rewrite the main build script (#2319)
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request Feb 24, 2025
Merge branch 'dev' into fix-utxo-tx-fee-for-change
534006e 
* dev: (24 commits)
  fix(eth-tpu): remove state from funding validation (GLEECBTC#2334)
  improvement(rpc-server): rpc server dynamic port allocation (GLEECBTC#2342)
  fix(tests): fix or ignore unstable tests (GLEECBTC#2365)
  fix(fs): make `filter_files_by_extension` return only files (GLEECBTC#2364)
  fix(derive_key_from_path): check length of current_key_material (GLEECBTC#2356)
  chore(release): bump mm2 version to 2.4.0-beta (GLEECBTC#2346)
  fix(tests): add additional testnet sepolia nodes to test code (GLEECBTC#2358)
  fix(swaps): maintain legacy compatibility for negotiation messages (GLEECBTC#2353)
  refactor(SwapOps): impl defaults for protocol specific swapops fns (GLEECBTC#2354)
  feat(tpu-v2): provide swap protocol versioning (GLEECBTC#2324)
  feat(wallet): add change mnemonic password rpc (GLEECBTC#2317)
  fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (GLEECBTC#2261)
  feat(tendermint): unstaking/undelegation (GLEECBTC#2330)
  fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (GLEECBTC#2333)
  feat(event-streaming): API-driven subscription management (GLEECBTC#2172)
  fix(hash-types): remove panic, enforce fixed-size arrays (GLEECBTC#2279)
  fix(ARRR): store unconfirmed change output (GLEECBTC#2276)
  feat(tendermint): staking/delegation (GLEECBTC#2322)
  chore(deps): `timed-map` migration (GLEECBTC#2247)
  fix(mem-leak): `running_swap` never shrinks (GLEECBTC#2301)
  ...
@shamardy shamardy mentioned this pull request Apr 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimxy dimxy dimxy left review comments

@shamardy shamardy shamardy approved these changes

+2 more reviewers

@borngraced borngraced borngraced requested changes

@laruh laruh laruh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: protocol feature: RPC status: pending review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan @dimxy @shamardy @borngraced @laruh