fix(macos): codesign KDF with hardened runtime and timestamp#6
Draft
CharlVS wants to merge 3 commits intoKomodo-Community:devfrom
Draft
fix(macos): codesign KDF with hardened runtime and timestamp#6CharlVS wants to merge 3 commits intoKomodo-Community:devfrom
CharlVS wants to merge 3 commits intoKomodo-Community:devfrom
Conversation
…se double-signing\n\n- Extracted kdf_codesign helper to reduce duplication\n- Use printf for proper newline formatting\n- Sign in non-Release configs; keep post-thinning re-sign in Release\n\nRefs: PR #240 review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from upstream PR GLEECBTC#240
This PR ensures KDF artifacts are properly codesigned for macOS notarization.
Available for testing in GLEECBTC/gleec-wallet#3175
Changes:
Result: