feat(sia): add remaining fields and align with docs#1
Draft
CharlVS wants to merge 10 commits intoKomodo-Community:devfrom
Draft
feat(sia): add remaining fields and align with docs#1CharlVS wants to merge 10 commits intoKomodo-Community:devfrom
CharlVS wants to merge 10 commits intoKomodo-Community:devfrom
Conversation
thanks to @CharlVS 's patch file
standard withdraw models are being used regardless, with txJson and txHex added to WithdrawResult
other strategies use the completer approach with logging, which the sia strategy lacked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from upstream PR GLEECBTC#297
A modified version of @CharlVS's patch file, excluding the withdrawal strategy refactor, to reduce the scope of changes for the time being (although it would be good to add at a later stage).
Summary by CodeRabbit
New Features
Improvements
Removals