Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Aymara language = Bolivian flag to audio/subtitle overlay languages #2407

Closed
wants to merge 6 commits into from

Conversation

popeadam
Copy link
Contributor

@popeadam popeadam commented Jan 5, 2025

Description

Added Aymara language = Bolivian flag to audio/subtitle overlay languages doc and yml.
Fixed minor issue with a duplicate weighting

Type of Change

Please delete options that are not relevant.

  • [] New feature (non-breaking change which adds functionality)
  • [] Documentation change (non-code changes affecting only the wiki)

Checklist

Please delete options that are not relevant.

  • [] Updated Documentation to reflect changes

@YozoraXCII
Copy link
Contributor

Not disagreeing with any of these changes, but I notice that Bolivia itself isn't in the languages file, should it be?

@popeadam
Copy link
Contributor Author

popeadam commented Jan 5, 2025

Not disagreeing with any of these changes, but I notice that Bolivia itself isn't in the languages file, should it be?

Bolivia, or Bolivian, isn't a language. Aymara (ay is the code) is, and it's 3 million speakers predominantly live in Bolivia (bo is the flag). One (!) film has been made using it, AFAIK.

Does that help, or perhaps have I not understood the question correctly?

@YozoraXCII
Copy link
Contributor

YozoraXCII commented Jan 5, 2025

Not disagreeing with any of these changes, but I notice that Bolivia itself isn't in the languages file, should it be?

Bolivia, or Bolivian, isn't a language. Aymara (ay is the code) is, and it's 3 million speakers predominantly live in Bolivia (bo is the flag). One (!) film has been made using it, AFAIK.

Does that help, or perhaps have I not understood the question correctly?

It does, thanks :)

Only issue now is that again this PR incorporates other commits, such as adding in Irish which was already done? It's causing a conflict which prevents me from merging

@popeadam
Copy link
Contributor Author

popeadam commented Jan 5, 2025

Only issue now is that again this PR incorporates other commits, such as adding in Irish which was already done? It's causing a conflict which prevents me from merging

Dang, I synced my fork first but meh. Next time I'll delete and start over, I think it keeps trying to sync with the master branch.

@YozoraXCII
Copy link
Contributor

Closing, raised a new PR to add this.

@YozoraXCII YozoraXCII closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants