Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add original_language filter to dynamic_collections #754

Closed
hbooo opened this issue Mar 8, 2022 · 3 comments · Fixed by #762
Closed

[Feature]: Add original_language filter to dynamic_collections #754

hbooo opened this issue Mar 8, 2022 · 3 comments · Fixed by #762
Assignees
Labels
enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet

Comments

@hbooo
Copy link

hbooo commented Mar 8, 2022

Is your feature request related to a problem? Please elaborate.

I would like to create dynamic_collections based on spoken language in movies and tv shows

Describe the solution you'd like

Currently country is available for dynamic_collections but covers only movies and I would like to be able to generate collections based on the spoken language for movies and shows collection

Additional Information

Discord discussion : https://discord.com/channels/822460010649878528/949316725009154059

@hbooo hbooo added enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Mar 8, 2022
@YozoraXCII
Copy link
Contributor

Just wanted to throw a potential issue with this out there, I think it can be resolved though:

original_language relies on the metadata of the media within the library. Whilst this in itself is not an issue, we have seen that the original_language within the media's info tends to be written in the original language too. As an example of this, French would be written as français and Thai would be written as ไทย.

This can be resolved by using the pre_format_override attribute, but will involve a lot of time and effort for the end user to map every single language to its English counterpart. I think the more ideal approach would be for the original language dynamic collection's template to pre-map all of the language, which reduces the need of the user having to do it.

@bullmoose20
Copy link
Contributor

Country, Audio_language, original_language, would be great if the all translated to two-digit language codes to be standard

@YozoraXCII
Copy link
Contributor

YozoraXCII commented Mar 8, 2022

Country, Audio_language, original_language, would be great if the all translated to two-digit language codes to be standard

Completely agree with the request to standardize to the two-digit ISO code as much as possible, but my above issue will persist. You will either have collections called "ไทย" and "Français", or collections named "th" and "fr".

The data from the API needs to be mapped to English variants so that the collection names are understandable. I believe Plex takes these codes and then translates them within the UI so you see "French" and "Thai" as the language tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants