Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for TMDb Discover with_release_type #464

Closed
snown opened this issue Nov 28, 2021 · 0 comments · Fixed by #465
Closed

Feature Request: Add support for TMDb Discover with_release_type #464

snown opened this issue Nov 28, 2021 · 0 comments · Fixed by #465
Assignees
Labels
enhancement New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@snown
Copy link

snown commented Nov 28, 2021

Is your feature request related to a problem? Please describe.
The recent update to the TMDb Discover attributes added support for the with_type Discover TV attribute, but did not add the equivalent with_release_type Discover Movie attribute.

Describe the solution you'd like
I would like the with_release_type attribute to be added to tmdb_discover so I can filter matches based whether or not a movie had a specific type of release.

It would be nice to filter results based on release type.
1 = Premiere
2 = Theatrical (limited)
3 = Theatrical
4 = Digital
5 = Physical
6 = TV

Additional info
What would BEST suit my needs, would actually be a without_release_type. However, that doesn't seem to be supported by the TMDb API, and I think to do it ourselves would require calling the GET movie release dates endpoint for each match, which seems like a bad idea. If you can think of a way around this limitation I'd greatly appreciate it, but I didn't make it officially part of this request because it seems out of scope, and perhaps separate ticket.

I am of course willing to help and create Pull Requests if you'd like.

@snown snown added enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Nov 28, 2021
@meisnate12 meisnate12 added status:added-to-develop Feature Request or Bug Fix is in Develop and removed status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Nov 29, 2021
@meisnate12 meisnate12 mentioned this issue Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants