Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Library specific search in a collection #341

Closed
Alaksin opened this issue Jul 20, 2021 · 5 comments
Closed

Feature Request: Library specific search in a collection #341

Alaksin opened this issue Jul 20, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request priority:low Low priority bug or feature

Comments

@Alaksin
Copy link

Alaksin commented Jul 20, 2021

Is your feature request related to a problem? Please describe.
Having cross-library collections often requires having different specifications of the collection in each library. One issue is that some options are only valid in a movie or a TV show library. You can't put them both into one definition since the script will crash if the option isn't allowed. This adds a lot of extra lines to the yml files and makes it more difficult to keep things tidy.

Describe the solution you'd like
It would be a lot easier to be able to specify a collection in one place. This would require that you can set search criterias for different libraries in the collection or template specification. Here's an example:

templates:

  Director:
    sync_mode: sync
    collection_order: release
    tmdb_person: <<person>>
    sort_title: ΩΩ5 <<collection_name>>
    name_mapping: "- People/<<collection_name>>"
    libraries:
      Movies:
        plex_search:
        any:
          director: tmdb
      Documentary Movies:
        plex_search:
        any:
          director: tmdb
      TV Shows:
       plex_search:
       any:
         title: <<title>>

collections:
  Lars von Trier:
    template:
      name: Director
      person: 42
      title: Riget

  Oliver Stone:
    template:
      name: Director
      person: 1152
      title:
        - Untold History of the United States
        - Putin Interviews
@Alaksin Alaksin added enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Jul 20, 2021
@meisnate12 meisnate12 added priority:low Low priority bug or feature and removed status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Jul 20, 2021
meisnate12 added a commit that referenced this issue Jul 30, 2021
@meisnate12
Copy link
Member

ok i went a slightly different route i added validate_builders as a collection detail by default this is set to true if you set it to false the program wont throw errors when a builder fails and if you want plex_search or smart_filter attributes to not fail you can also add validate: false to the top level under either

@Alaksin
Copy link
Author

Alaksin commented Aug 5, 2021

That can be useful but it doesn't solve my request. To be able to specify different rules for different libraries in the collection itself is what I'm requesting. Sometimes a search option is usable across libraries. Just as an example, say I have a collection for the band Queen. Works great to search on just the title Queen in the Concerts library, but searching for it in the Movies library it can give all sorts of results. I understand I can work around the rules and utilize the validation to get what I want, but it's a matter of simplicity and readability. There will also be a lot of "hard" rules like exact movie titles or IDs. It's much easier to maintain simple and broad rules. I also like to avoid having to use rules that I know don't work or that I don't want to search for in certain libraries.

@meisnate12
Copy link
Member

I get the initial request it's just a lot of extra coding to get things working like your asking. I was hoping validate_builders would help since I could add that a lot easier. The Program was designed with the idea of one Metadata file per library so it won't be quick to do what your asking. You could accomplish what you want by splitting your file a little bit. Just have a different Metadata file per library and have a shared metadata file for the collections that are the same for both libraries. I'll leave the request open I'm just not sure when ill get around to it because my next and highest priority for PMM is building a GUI and I want to put my time into that since once its done we wont need yaml files anyways.

@Alaksin
Copy link
Author

Alaksin commented Aug 14, 2021

I understand it can require some rewriting and I know I can accomplish it with some workarounds. I just really like the idea of specifying a Collection in one place, no matter how libraries it will be in. Anyway, if you are going to make a GUI maybe this is something you can take into consideration for that. Like when you edit a collection you can edit for all the libraries and such. Really looking forward to seeing the GUI, but I guess it will take some time, not the easiest task to make something for all these configurations.

@meisnate12 meisnate12 mentioned this issue Aug 15, 2021
@meisnate12
Copy link
Member

i dont plan on adding this feature so I'm going to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority bug or feature
Projects
None yet
Development

No branches or pull requests

2 participants