Skip to content

Conversation

@knuesel
Copy link
Contributor

@knuesel knuesel commented Jul 20, 2021

This switches to new GeometryBasics type names from JuliaGeometry/GeometryBasics.jl#97.

@Kolaru
Copy link
Owner

Kolaru commented Jul 21, 2021

Could you bump the [compat] entry in Project.toml so that we use the new version of GeometryBasics (and the tests pass)?

@knuesel
Copy link
Contributor Author

knuesel commented Jul 21, 2021

Yep I'll bump the GeometryBasics version as soon as it's released, but AFAICS the latest release doesn't include the PR...

@knuesel
Copy link
Contributor Author

knuesel commented Jul 21, 2021

@Kolaru the [compat] entry is updated, tests should pass now.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #14 (5f8bbc7) into master (22152b9) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   79.26%   79.26%           
=======================================
  Files           8        8           
  Lines         410      410           
=======================================
  Hits          325      325           
  Misses         85       85           
Impacted Files Coverage Δ
src/MathTeXEngine.jl 100.00% <ø> (ø)
src/engine/texelements.jl 85.24% <ø> (ø)
src/prototype.jl 0.00% <0.00%> (ø)
src/engine/layout.jl 96.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22152b9...5f8bbc7. Read the comment docs.

@Kolaru
Copy link
Owner

Kolaru commented Jul 21, 2021

Perfect, thanks a lot!

@Kolaru Kolaru merged commit 238bf49 into Kolaru:master Jul 21, 2021
@knuesel
Copy link
Contributor Author

knuesel commented Jul 21, 2021

Thanks for merging! Would it be possible to have a release soon (so we can merge the same changes in Makie)?

@Kolaru
Copy link
Owner

Kolaru commented Jul 22, 2021

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants