Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adapt SP 24x converter for new firmware version #8715

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mundschenk-at
Copy link
Contributor

@mundschenk-at
Copy link
Contributor Author

@Koenkk Ideally, fingerprinting should allow to specify a minimum/maximum firmware version to support both the old and the new FW. To keep things simple, I'm thinking of basing it on dateCode (instead of the softwareBuildID), does that sound right? To make sure there are no compatibility issues, I'd have to add separate constraint fields. Or would it be better to make a general mechanism here?

@Koenkk
Copy link
Owner

Koenkk commented Feb 2, 2025

, I'm thinking of basing it on dateCode (instead of the softwareBuildID), does that sound right?

Currently we cannot do a greater/less than match in the fingerprint, I think it would be the easiest if everyone upgrades their plugs?

@mundschenk-at
Copy link
Contributor Author

Personally, I'm OK with that, but the greater/less than matching could be added easily (though not very elegant) with new fields.

@Koenkk
Copy link
Owner

Koenkk commented Feb 2, 2025

How many old versions are there? If there is just 1 or 2 we could easily do it with the fingerprint.

@mundschenk-at
Copy link
Contributor Author

I don't know (I've asked @GerryInnr) but at least four (1.4.3, 1.6.22, 1.6.24, and 1.7.23).

@AlexanderLeporiday
Copy link

, I'm thinking of basing it on dateCode (instead of the softwareBuildID), does that sound right?

Currently we cannot do a greater/less than match in the fingerprint, I think it would be the easiest if everyone upgrades their plugs?

I think it's fair to say that they must update the latest version for all fixes. I was just concerned about people who buy the item off the shelf in the future, which is running a much older firmware, and if they run it against a newer version of the converter, they will run into issues. But these issues would be resolved by doing an update of the firmware. I can't see any reason why people wouldn't be able to upgrade the firmware.

I was more curious about how it's been handled with other products that introduce changes to the converter that older firmware would not be compatible with.

@GerryInnr
Copy link

GerryInnr commented Feb 3, 2025

I don't know (I've asked @GerryInnr) but at least four (1.4.3, 1.6.22, 1.6.24, and 1.7.23).

Hi guys, sorry for the late reply, had a social obligation yesterday.
I agree that the best solution would be to have the users upgrade to the latest versions. In that case, the converter coud be adjusted to remove all the multipliers and divisors since the devices provide them all with the right values.

Just in case, here's the overview of possible firmware versions:

v1 plugs (ImageTypes 0x0331 to 0x0333): 1.4.3, 1.6.22, 1.7.20, 1.7.22, 1.7.23
v2 plugs (ImageTypes 0x0334 to 0x0336): 1.6.24, 1.7.20, 1.7.22, 1.7.23.
0x0331/0x0334 = SP 240 (v2)
0x0332/0x0335 = SP 242 (v2)
0x0333/0x0336 = SP 244 (v2)

@mundschenk-at
Copy link
Contributor Author

I guess those probably too many to handle without conditional fingerprinting. I can try to add a less-than/greater-than condition to fingerprinting or everyone just has to update for the device to work properly. Both solutions are fine by me, your call @Koenkk

@Koenkk
Copy link
Owner

Koenkk commented Feb 3, 2025

to update for the device to work properly

@GerryInnr also agrees that people just have to update, so let's go for that.

@mundschenk-at mundschenk-at changed the title feat: Adapt SP 24x converter for new firmware version fix: Adapt SP 24x converter for new firmware version Feb 3, 2025
@mundschenk-at mundschenk-at marked this pull request as ready for review February 3, 2025 21:33
@Koenkk Koenkk merged commit 67c008d into Koenkk:master Feb 4, 2025
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Feb 4, 2025

Many thanks!

@mundschenk-at mundschenk-at deleted the innr-sp-24x branch February 4, 2025 20:32
@hmmbob
Copy link

hmmbob commented Feb 6, 2025

For those updating to 2.1.1 with the new firmware and still seeing wrong values:

You need to hit the "reconfigure" button of the device in the zigbee2mqtt frontend (it's the yellow arrows button) before the changes come into effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divisors need updating after SP 242 firmware update
5 participants