-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adapt SP 24x converter for new firmware version #8715
Conversation
@Koenkk Ideally, fingerprinting should allow to specify a minimum/maximum firmware version to support both the old and the new FW. To keep things simple, I'm thinking of basing it on |
Currently we cannot do a greater/less than match in the fingerprint, I think it would be the easiest if everyone upgrades their plugs? |
Personally, I'm OK with that, but the greater/less than matching could be added easily (though not very elegant) with new fields. |
How many old versions are there? If there is just 1 or 2 we could easily do it with the fingerprint. |
I don't know (I've asked @GerryInnr) but at least four ( |
I think it's fair to say that they must update the latest version for all fixes. I was just concerned about people who buy the item off the shelf in the future, which is running a much older firmware, and if they run it against a newer version of the converter, they will run into issues. But these issues would be resolved by doing an update of the firmware. I can't see any reason why people wouldn't be able to upgrade the firmware. I was more curious about how it's been handled with other products that introduce changes to the converter that older firmware would not be compatible with. |
Hi guys, sorry for the late reply, had a social obligation yesterday. Just in case, here's the overview of possible firmware versions: v1 plugs (ImageTypes 0x0331 to 0x0333): 1.4.3, 1.6.22, 1.7.20, 1.7.22, 1.7.23 |
I guess those probably too many to handle without conditional fingerprinting. I can try to add a less-than/greater-than condition to fingerprinting or everyone just has to update for the device to work properly. Both solutions are fine by me, your call @Koenkk |
@GerryInnr also agrees that people just have to update, so let's go for that. |
e6f6ca1
to
2891a7f
Compare
2891a7f
to
b5355cd
Compare
Many thanks! |
For those updating to 2.1.1 with the new firmware and still seeing wrong values: You need to hit the "reconfigure" button of the device in the zigbee2mqtt frontend (it's the yellow arrows button) before the changes come into effect. |
divisor
/multiplier
settings.reconfigureReportingsOnDeviceAnnounce()
call forSP 242
.SP 242
andSP 244
as white label devices.